Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to merge PA-RTF #651

Merged
merged 36 commits into from
Jun 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
4ec8da2
PA RTF merging init
atharvasharma61 Apr 22, 2024
a68d0fb
working model
atharvasharma61 Apr 22, 2024
2fecd36
working model tip
atharvasharma61 Apr 22, 2024
5ec43af
functional model init
atharvasharma61 Apr 22, 2024
b19e35f
Migrated HeapMetricsCollector
atharvasharma61 Apr 25, 2024
791e99a
Merge branch 'opensearch-project:main' into pa-rtf
atharvasharma61 Apr 25, 2024
d77c71f
Added RTFThreadPoolMetricsCollector
atharvasharma61 May 7, 2024
7072a65
migrated NodeStats and DiskMetricsCollector
atharvasharma61 May 13, 2024
8e43e03
Added gauge data model for Heap_Max metric
atharvasharma61 May 17, 2024
4d5dec4
implemented TelemetryAwarePlugin
atharvasharma61 May 20, 2024
ef28130
Merge branch 'opensearch-project:main' into pa-rtf
atharvasharma61 May 30, 2024
49946a6
Framework changes for PA RTF merging
atharvasharma61 May 30, 2024
82e15e7
refactored
atharvasharma61 May 30, 2024
8922651
spotless applied
atharvasharma61 May 30, 2024
a80873f
Addressed small comments
atharvasharma61 May 31, 2024
e39aada
Added different flag for RCA collectors
atharvasharma61 May 31, 2024
97dd4bc
Addressed more comments
atharvasharma61 May 31, 2024
e9b5d57
Added RTF collectors in config map
atharvasharma61 May 31, 2024
538d682
Added UTs
atharvasharma61 May 31, 2024
f182464
Added further UTs
atharvasharma61 Jun 1, 2024
447e15f
Added dynamic control support to all collectors
atharvasharma61 Jun 3, 2024
369bd95
fixed UT
atharvasharma61 Jun 3, 2024
25d66e8
refactoring
atharvasharma61 Jun 3, 2024
84580dc
Revert "refactoring"
atharvasharma61 Jun 4, 2024
16c592e
Revert "fixed UT"
atharvasharma61 Jun 4, 2024
55a7604
Revert "Added dynamic control support to all collectors"
atharvasharma61 Jun 4, 2024
837b15d
Adding two new collector interfaces
atharvasharma61 Jun 4, 2024
96166aa
simplified interfaces
atharvasharma61 Jun 4, 2024
a9a756f
Added units and javadocs
atharvasharma61 Jun 5, 2024
8df65a5
Changes metrics semantic conventions
atharvasharma61 Jun 5, 2024
7213080
refactored
atharvasharma61 Jun 5, 2024
857214b
fixed UT
atharvasharma61 Jun 5, 2024
da1c4ba
Added stats metrics for rtf collectors
atharvasharma61 Jun 6, 2024
1e211f0
reverted test delete
atharvasharma61 Jun 6, 2024
44f0b7c
Fixes javadoc compilation issue
Jun 10, 2024
870e3a5
Merge branch 'opensearch-project:main' into pa-rtf
atharvasharma61 Jun 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes javadoc compilation issue
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gagan Juneja committed Jun 10, 2024
commit 44f0b7c36b622ab75f3249ce0aadc3e65b10df7c
Original file line number Diff line number Diff line change
@@ -40,8 +40,8 @@ public enum PerformanceAnalyzerFeatureBits {
Setting.Property.Dynamic);

/**
* Cluster setting controlling the collector mode : 0 -> only RCA Collectors enabled (Default) 1
* -> only Telemetry Collectors enabled 2 -> both RCA and Telemetry Collectors enabled
* Cluster setting controlling the collector mode : 0 - only RCA Collectors enabled (Default) 1
* - only Telemetry Collectors enabled 2 - both RCA and Telemetry Collectors enabled
*/
public static final Setting<Integer> PA_COLLECTORS_SETTING =
atharvasharma61 marked this conversation as resolved.
Show resolved Hide resolved
Setting.intSetting(
Original file line number Diff line number Diff line change
@@ -32,8 +32,8 @@ public PerformanceAnalyzerCollectorsSettingHandler(
/**
* Updates the Collectors mode setting across the cluster.
*
* @param value The desired collector mode amongst: * 0 -> only RCA Collectors enabled (Default)
* * 1 -> only Telemetry Collectors enabled * 2 -> both RCA and Telemetry Collectors enabled
* @param value The desired collector mode amongst: 0 - only RCA Collectors enabled (Default) *
* 1 - only Telemetry Collectors enabled * 2 - both RCA and Telemetry Collectors enabled
*/
public void updateCollectorsSetting(final int value) {
clusterSettingsManager.updateSetting(