Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collector] Adding Latency and Error service metrics #442

Merged
merged 3 commits into from
May 17, 2023

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented May 17, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
opensearch-project/performance-analyzer-rca#363

Describe the solution you are proposing
[Collector] Adding Latency and Error service metrics

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #442 (b726e3e) into main (f65f8f9) will increase coverage by 0.18%.
The diff coverage is 43.83%.

❗ Current head b726e3e differs from pull request most recent head e3d30db. Consider uploading reports for the commit e3d30db to get more accurate results

@@             Coverage Diff              @@
##               main     #442      +/-   ##
============================================
+ Coverage     71.95%   72.13%   +0.18%     
- Complexity      374      375       +1     
============================================
  Files            44       44              
  Lines          2560     2591      +31     
  Branches        173      173              
============================================
+ Hits           1842     1869      +27     
- Misses          609      614       +5     
+ Partials        109      108       -1     
Impacted Files Coverage Δ
...ollectors/ClusterApplierServiceStatsCollector.java 78.66% <0.00%> (ø)
...tors/ClusterManagerThrottlingMetricsCollector.java 0.00% <ø> (ø)
...anceanalyzer/collectors/ElectionTermCollector.java 76.31% <0.00%> (ø)
...zer/collectors/FaultDetectionMetricsCollector.java 0.00% <ø> (ø)
...lectors/ShardIndexingPressureMetricsCollector.java 9.25% <0.00%> (-0.24%) ⬇️
...rmanceanalyzer/collectors/ShardStateCollector.java 15.94% <0.00%> (ø)
...nalyzer/config/setting/ClusterSettingsManager.java 5.88% <ø> (ø)
...er/listener/PerformanceAnalyzerSearchListener.java 81.34% <0.00%> (ø)
...ormanceanalyzer/writer/EventLogQueueProcessor.java 60.71% <0.00%> (+4.76%) ⬆️
...r/collectors/AdmissionControlMetricsCollector.java 17.10% <33.33%> (+2.43%) ⬆️
... and 9 more

@khushbr khushbr merged commit 9524c08 into opensearch-project:main May 17, 2023
khushbr added a commit to khushbr/performance-analyzer that referenced this pull request May 17, 2023
…ect#442)

* [Collector] Adding Latency and Error service metrics

Signed-off-by: Khushboo Rajput <[email protected]>

* Removing fastdoubleparser-LICENSE.tx

* Removing fastdoubleparser-NOTICE.txt

Signed-off-by: Khushboo Rajput <[email protected]>

---------

Signed-off-by: Khushboo Rajput <[email protected]>
khushbr added a commit that referenced this pull request May 17, 2023
* Update RestController constructor for tests. (#440)

Signed-off-by: Filip Drobnjakovic <[email protected]>

* Fixing ShardStateCollector; impacted by core refactoring

Signed-off-by: Khushboo Rajput <[email protected]>

* [Collector] Adding Latency and Error service metrics (#442)

* [Collector] Adding Latency and Error service metrics

Signed-off-by: Khushboo Rajput <[email protected]>

* Removing fastdoubleparser-LICENSE.txt and fastdoubleparser-NOTICE.txt

Signed-off-by: Khushboo Rajput <[email protected]>

---------

Signed-off-by: Khushboo Rajput <[email protected]>

* License changes

Signed-off-by: Khushboo Rajput <[email protected]>

---------

Signed-off-by: Filip Drobnjakovic <[email protected]>
Signed-off-by: Khushboo Rajput <[email protected]>
Co-authored-by: Filip Drobnjaković <[email protected]>
@khushbr khushbr deleted the collector-latency-metric branch May 31, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants