Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collector Service Metrics #365

Merged
merged 2 commits into from
May 17, 2023

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented May 17, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Collector latency metrics

Describe the solution you are proposing

  • Adding Collector Metrics and refactoring the Error metrics
  • Plugging Writer metrics in collectors. Also added metrics for COLLECTORS_SLOW and COLLECTORS_SKIPPED collector in scheduler to help identify lagging collectors.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #365 (7dbc31b) into main (6a4b031) will decrease coverage by 0.01%.
The diff coverage is 72.41%.

❗ Current head 7dbc31b differs from pull request most recent head e00e2e4. Consider uploading reports for the commit e00e2e4 to get more accurate results

@@             Coverage Diff              @@
##               main     #365      +/-   ##
============================================
- Coverage     72.84%   72.83%   -0.01%     
+ Complexity     3044     3043       -1     
============================================
  Files           381      381              
  Lines         19059    19105      +46     
  Branches       1472     1472              
============================================
+ Hits          13883    13916      +33     
- Misses         4579     4592      +13     
  Partials        597      597              
Impacted Files Coverage Δ
...ormanceanalyzer/collectors/OSMetricsCollector.java 1.80% <0.00%> (-0.06%) ⬇️
.../collectors/ScheduledMetricCollectorsExecutor.java 12.98% <0.00%> (-1.10%) ⬇️
...ceanalyzer/metrics/PerformanceAnalyzerMetrics.java 37.97% <0.00%> (ø)
...performanceanalyzer/net/GRPCConnectionManager.java 82.41% <ø> (ø)
.../opensearch/performanceanalyzer/net/NetServer.java 68.67% <ø> (ø)
...eanalyzer/rca/framework/metrics/ReaderMetrics.java 100.00% <ø> (ø)
...ormanceanalyzer/reader/ReaderMetricsProcessor.java 78.53% <0.00%> (ø)
...yzer/reader_writer_shared/EventLogFileHandler.java 26.04% <0.00%> (ø)
...opensearch/performanceanalyzer/jvm/ThreadList.java 12.03% <14.28%> (ø)
...h/performanceanalyzer/reader/OSEventProcessor.java 81.08% <50.00%> (-0.87%) ⬇️
... and 7 more

... and 4 files with indirect coverage changes

@khushbr khushbr merged commit e420988 into opensearch-project:main May 17, 2023
@khushbr khushbr deleted the collector-latency-metrics branch May 17, 2023 16:59
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 17, 2023
* Adding Collector Metrics and refactoring the Error metrics

Signed-off-by: Khushboo Rajput <[email protected]>

* Plugging Writer metrics in collectors. Also added metrics for slow and skipped collector in scheduler

Signed-off-by: Khushboo Rajput <[email protected]>

---------

Signed-off-by: Khushboo Rajput <[email protected]>
(cherry picked from commit e420988)
khushbr added a commit that referenced this pull request May 17, 2023
* Adding Collector Metrics and refactoring the Error metrics

Signed-off-by: Khushboo Rajput <[email protected]>

* Plugging Writer metrics in collectors. Also added metrics for slow and skipped collector in scheduler

Signed-off-by: Khushboo Rajput <[email protected]>

---------

Signed-off-by: Khushboo Rajput <[email protected]>
(cherry picked from commit e420988)

Co-authored-by: Khushboo Rajput <[email protected]>
@opensearch-trigger-bot
Copy link

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-365-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e4209880be67968a9ac1df322294dd957a99e371
# Push it to GitHub
git push --set-upstream origin backport/backport-365-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-365-to-2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants