Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run docker OS cluster with different JDK versions #275

Closed
wants to merge 2 commits into from
Closed

Run docker OS cluster with different JDK versions #275

wants to merge 2 commits into from

Conversation

Tjofil
Copy link
Contributor

@Tjofil Tjofil commented Jan 23, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Issue #162

Describe the solution you are proposing
Workflow matrix parameter is passed through gradle argument and then to Dockerfile where corresponding JDK version is downloaded and placed in the plain 'jdk' folder to reduce further parameterization and complication of Dockerfile.
Also we add conditional jvm.options hack line because of #161, once it's solved we can get rid of it.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Filip Drobnjakovic <[email protected]>
@Tjofil Tjofil requested a review from a team January 23, 2023 10:21
@codecov-commenter
Copy link

Codecov Report

Merging #275 (40107b8) into main (e0d6a0c) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 40107b8 differs from pull request most recent head eabc15d. Consider uploading reports for the commit eabc15d to get more accurate results

@@             Coverage Diff              @@
##               main     #275      +/-   ##
============================================
- Coverage     71.57%   71.50%   -0.07%     
+ Complexity     2989     2985       -4     
============================================
  Files           380      380              
  Lines         18984    18984              
  Branches       1463     1463              
============================================
- Hits          13587    13574      -13     
- Misses         4803     4812       +9     
- Partials        594      598       +4     
Impacted Files Coverage Δ
...nalyzer/rca/net/handler/PublishRequestHandler.java 73.46% <0.00%> (-14.29%) ⬇️
...nceanalyzer/rca/samplers/MetricsDBFileSampler.java 75.00% <0.00%> (-9.10%) ⬇️
...ceanalyzer/rca/store/rca/hotshard/HotShardRca.java 86.13% <0.00%> (-1.00%) ⬇️
...performanceanalyzer/collectors/StatsCollector.java 92.59% <0.00%> (-0.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Tjofil Tjofil closed this Jan 23, 2023
@Tjofil Tjofil deleted the docker_build_with_param_jdk branch January 23, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants