Changes to add jdk17, remove jdk 8,14, OS 2.0 and upgrade to gradle 7 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
…k 17 Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
============================================
- Coverage 72.02% 71.92% -0.10%
+ Complexity 2962 2949 -13
============================================
Files 376 376
Lines 18834 18783 -51
Branches 1465 1442 -23
============================================
- Hits 13565 13510 -55
+ Misses 4685 4676 -9
- Partials 584 597 +13
Continue to review full report at Codecov.
|
sruti1312
previously approved these changes
Apr 5, 2022
| @@ -103,7 +103,7 @@ testlogger { | |||
| spotbugsMain { | |||
| excludeFilter = file("checkstyle/findbugs-exclude.xml") | |||
| effort = 'max' | |||
| ignoreFailures = false | |||
| ignoreFailures = true // TODO: Set this to false later as they are too many warnings to be fixed. | |||
There was a problem hiding this comment.
If we are not planning to fix this now, can we open an issue and link it here?
Looks like you fixed almost all the issues.
There was a problem hiding this comment.
I have created issue - #157 to track this.
There are still many medium related warnings which needs to be fixed. I fixed high priority ones.
Signed-off-by: Sagar Upadhyaya <[email protected]>
sgup432
changed the title
Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar Upadhyaya <[email protected]>
sruti1312
previously approved these changes
Apr 6, 2022
Signed-off-by: Sagar Upadhyaya <[email protected]>
|
Though JDK 11, 17 CI is failing, will be pushing these changes. As this RCA PR rely on PA where OS 2.0, gradle 7, jdk 17 changes are still in PR phase. Will take care there. Had tested these changes with pointing to PA non main branch which had desired changes. |
dzane17
approved these changes
Apr 6, 2022
sruti1312
approved these changes
Apr 6, 2022
24 tasks
1 task
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sagar Upadhyaya [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.