Fixing unit tests due to latest changes

Signed-off-by: Sagar Upadhyaya <[email protected]>
opensearch-project · Apr 5, 2022 · 5ae5003 · 5ae5003
1 parent eb09ab5
commit 5ae5003
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 3 deletions.
diff --git a/...ava/org/opensearch/performanceanalyzer/rca/framework/api/summaries/HotClusterSummary.java b/...ava/org/opensearch/performanceanalyzer/rca/framework/api/summaries/HotClusterSummary.java
@@ -188,6 +188,9 @@ public String getName() {
      */
     @Nullable
     public static HotClusterSummary buildSummary(Record record) {
+        if (record == null) {
+            return null;
+        }
         HotClusterSummary summary = null;
         try {
             Integer numOfNodes =

diff --git a/...va/org/opensearch/performanceanalyzer/rca/framework/api/summaries/HotResourceSummary.java b/...va/org/opensearch/performanceanalyzer/rca/framework/api/summaries/HotResourceSummary.java
@@ -316,6 +316,9 @@ public String getName() {
      */
     @Nullable
     public static HotResourceSummary buildSummary(Record record) {
+        if (record == null) {
+            return null;
+        }
         HotResourceSummary summary = null;
         try {
             int resourceTypeEnumVal =

diff --git a/.../java/org/opensearch/performanceanalyzer/rca/framework/api/summaries/HotShardSummary.java b/.../java/org/opensearch/performanceanalyzer/rca/framework/api/summaries/HotShardSummary.java
@@ -281,6 +281,9 @@ public String getName() {
      */
     @Nullable
     public static HotShardSummary buildSummary(final Record record) {
+        if (record == null) {
+            return null;
+        }
         HotShardSummary summary = null;
         try {
             String indexName =

diff --git a/src/main/java/org/opensearch/performanceanalyzer/rca/response/RcaResponse.java b/src/main/java/org/opensearch/performanceanalyzer/rca/response/RcaResponse.java
@@ -53,6 +53,9 @@ public long getTimeStamp() {
     }
 
     public static RcaResponse buildResponse(Record record) {
+        if (record == null) {
+            return null;
+        }
         RcaResponse response = null;
         try {
             String rcaName =

diff --git a/src/test/java/org/opensearch/performanceanalyzer/rca/response/RcaResponseTest.java b/src/test/java/org/opensearch/performanceanalyzer/rca/response/RcaResponseTest.java
@@ -77,9 +77,7 @@ public void testBuildResponseDurability() {
         Mockito.when(record.get(isA(Field.class), any(Class.class)))
                 .thenThrow(new DataTypeException("uh-oh"));
         Assert.assertNull(RcaResponse.buildResponse(record));
-        Mockito.when(record.get(isA(Field.class), any(Class.class)))
-                .thenThrow(new NullPointerException());
-        Assert.assertNull(RcaResponse.buildResponse(record));
+        Assert.assertNull(RcaResponse.buildResponse(null));
     }
 
     @Test