-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aliasing regression in post install script #695
Fix aliasing regression in post install script #695
Conversation
Signed-off-by: Matt Provost <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you find the issue and validate that this change is what fixes it?
Plugged the current version into Dashboards, ran |
Cool. For what it's worth, you should be able to directly test against OUI |
Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit 1c3d9bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit 1c3d9bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit 1c3d9bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 1c3d9bc) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 1c3d9bc) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 1c3d9bc) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Previously, in 9abf87e, there was an aliasing regression in
scripts/postinstall.js
. Essentially it didn't rename files to their EUI counterpart. This PR fixes that and prepares OUI for the 1.1 releaseCheck List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.