Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliasing regression in post install script #695

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Apr 11, 2023

Description

Previously, in 9abf87e, there was an aliasing regression in scripts/postinstall.js. Essentially it didn't rename files to their EUI counterpart. This PR fixes that and prepares OUI for the 1.1 release

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <[email protected]>
@BSFishy BSFishy changed the title Fix aliasing issue Fix aliasing regression in post install script Apr 11, 2023
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find the issue and validate that this change is what fixes it?

@BSFishy
Copy link
Contributor Author

BSFishy commented Apr 12, 2023

How did you find the issue and validate that this change is what fixes it?

Plugged the current version into Dashboards, ran yarn test:jest and yarn test:jest_integration and some errors popped up about these files not being found. Tested by publishing the fixed version to personal NPM account and testing the same thing with that version

@joshuarrrr
Copy link
Member

How did you find the issue and validate that this change is what fixes it?

Plugged the current version into Dashboards, ran yarn test:jest and yarn test:jest_integration and some errors popped up about these files not being found. Tested by publishing the fixed version to personal NPM account and testing the same thing with that version

Cool. For what it's worth, you should be able to directly test against OUI main by just setting the dependency in dashboards to point to the OUI git repo, which may be a little quicker.

@joshuarrrr joshuarrrr merged commit 1c3d9bc into opensearch-project:main Apr 12, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 12, 2023
Signed-off-by: Matt Provost <[email protected]>
(cherry picked from commit 1c3d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 12, 2023
Signed-off-by: Matt Provost <[email protected]>
(cherry picked from commit 1c3d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 12, 2023
Signed-off-by: Matt Provost <[email protected]>
(cherry picked from commit 1c3d9bc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Apr 13, 2023
(cherry picked from commit 1c3d9bc)

Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc pushed a commit that referenced this pull request May 25, 2023
(cherry picked from commit 1c3d9bc)

Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki pushed a commit that referenced this pull request Jun 20, 2023
(cherry picked from commit 1c3d9bc)

Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants