Add 2 party approval process for releases #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Provost <[email protected]>
BSFishy
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX and
bandinib-amzn
as code owners
|
Why cant we use Githubs built in feature for this? https://docs.github.com/en/actions/managing-workflow-runs/reviewing-deployments |
Org-wide approaches investigated here: opensearch-project/opensearch-build#3111 |
joshuarrrr
approved these changes
Apr 11, 2023
ashwin-pc
approved these changes
Apr 12, 2023
AMoo-Miki
approved these changes
Apr 12, 2023
bandinib-amzn
approved these changes
Apr 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit 2229dd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit 2229dd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit 2229dd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
that referenced
this pull request
May 25, 2023
(cherry picked from commit 2229dd4) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Jun 28, 2023
(cherry picked from commit 2229dd4) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Jun 28, 2023
(cherry picked from commit 2229dd4) Signed-off-by: Matt Provost <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 2 party approval process for releases. Makes sure releases are truly intended and go through multiple parties before being cut
Issues Resolved
Closes #691
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.