[CCI] Update tabbable dependency #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]>
andreymyssak
force-pushed
the
594-update-tabble
branch
from
626b0b8 to
fba1a18
Compare
BSFishy
reviewed
Mar 31, 2023
Comment on lines
+273
to
+275
| const tabbableItems = tabbable(this.content, { | ||
| displayCheck: 'legacy-full', | ||
| }); |
There was a problem hiding this comment.
Why is this the only instance where options are added to the tabbable call? Is it special for some reason? Should the other calls to tabbable have it too?
There was a problem hiding this comment.
The rest of the cases do not cause problems with the tests and smoothly support the transition to the new version. In this file apparently a different case, after the upgrade the tests did not behave correctly, so I had to apply legacy-full.
There was a problem hiding this comment.
Let's open a follow-up issue to see if we can refactor and remove.
BSFishy
approved these changes
Apr 5, 2023
ashwin-pc
approved these changes
Apr 8, 2023
joshuarrrr
approved these changes
Apr 11, 2023
Comment on lines
+273
to
+275
| const tabbableItems = tabbable(this.content, { | ||
| displayCheck: 'legacy-full', | ||
| }); |
There was a problem hiding this comment.
Let's open a follow-up issue to see if we can refactor and remove.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
Signed-off-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> (cherry picked from commit 419b57c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Jul 2, 2023
(cherry picked from commit 419b57c) Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sergey Myssak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update tabbable dependency to 6.1.1
Issues Resolved
#594
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.