-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCI] Fix deprecated webpack configuration #578
Merged
BSFishy
merged 1 commit into
opensearch-project:main
from
SergeyMyssak:577-Fix-deprecated-webpack-configuration
Mar 10, 2023
Merged
[CCI] Fix deprecated webpack configuration #578
BSFishy
merged 1 commit into
opensearch-project:main
from
SergeyMyssak:577-Fix-deprecated-webpack-configuration
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Myssak <[email protected]>
SergeyMyssak
changed the title
Fix deprecated webpack configuration (#577)
[CCI] Fix deprecated webpack configuration (#577)
Mar 8, 2023
SergeyMyssak
changed the title
[CCI] Fix deprecated webpack configuration (#577)
[CCI] Fix deprecated webpack configuration
Mar 8, 2023
@SergeyMyssak This looks good and all automated tests pass. Any other guidance on the best way to validate/test? |
I think at the very least we need to make sure |
BSFishy
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes on yarn build
and yarn build-docs
ashwin-pc
approved these changes
Mar 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Sergey Myssak <[email protected]> (cherry picked from commit f936098) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Sergey Myssak <[email protected]> (cherry picked from commit f936098) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
that referenced
this pull request
Mar 10, 2023
(cherry picked from commit f936098) Signed-off-by: Sergey Myssak <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
that referenced
this pull request
Mar 10, 2023
(cherry picked from commit f936098) Signed-off-by: Sergey Myssak <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix deprecated webpack configuration
Issues Resolved
#577
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.