[OUI Docs] Updated the section Card #530
Conversation
Signed-off-by: AbhishekReddy1127 <[email protected]>
AbhishekReddy1127
force-pushed
the
OUI_Docs_Card
branch
from
c07d9e2 to
3ce167f
Compare
| title: 'Discover', | ||
| iconType: 'discoverApp', | ||
| }, | ||
| Kibana: { |
There was a problem hiding this comment.
Feels like some of these var names should be updated to not be so Elastic. Beats and Kibana should def be changed. Maybe update them to something similar to the title?
There was a problem hiding this comment.
Figma logo is getting cut off - perhaps this is because I provided the .svg as code from the figma website itself?
Maybe this helps instead - https://commons.wikimedia.org/wiki/File:Figma-logo.svg
| @@ -0,0 +1,3 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewBox="0 0 32 32" aria-label="FigmaLogo" alt="FigmaLogo"> | |||
There was a problem hiding this comment.
It looks like there is already a Figma icon: https://github.com/opensearch-project/oui/blob/fb2a386e82c6d836fb701aae4343b302e8605df4/src-docs/src/images/logo-figma.svg
| const badges = [null, 'Experimental']; | ||
|
|
||
| const cardNodes = icons.map(function (item, index) { | ||
| const cards = { | ||
| dashboard: { | ||
| title: 'Dashboards', | ||
| icon: 'dashboardApp', | ||
| }, | ||
| monitoring: { | ||
| title: 'Discover', | ||
| icon: 'discoverApp', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Could badges be added as another field in the cards object?
Description
Updated the text and icons in the section card.
Issues Resolved
#242
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.