Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Homepage #500

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Clean Homepage #500

merged 3 commits into from
Feb 27, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 21, 2023 •
edited
Loading

Before clean, homepage is

Screenshot 2023-02-21 at 15 27 51

After clean, now the homepage is like:

Screenshot 2023-02-21 at 15 18 16

  • no elastic image
  • no chart

Issues Resolved

#255

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ananzh ananzh requested a review from a team as a code owner February 21, 2023 23:25
@ananzh ananzh self-assigned this Feb 21, 2023
@kavilla kavilla linked an issue Feb 21, 2023 that may be closed by this pull request
(OUI Docs Site) Homepage #255
Closed
3 tasks
kavilla
kavilla reviewed Feb 22, 2023
View reviewed changes
src-docs/src/views/home/home_illustration.tsx Outdated

function Icon() {
const themeContext: any = useContext(ThemeContext);
//const themeContext: any = useContext(ThemeContext);
Copy link
Member

@kavilla kavilla Feb 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly thinking we should create a follow up issue to add a logo in the view if we want and delete this un used code.

Or delete this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay will change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not want to create a follow up issue to add a graphic here. I am being very judicious with how much time we spend on this forked site in favor of moving over to the storybook solution in the future. Lets move forward with delete.

@kavilla
Copy link
Member

kavilla commented Feb 22, 2023

Otherwise instead of changing the file you can actually just comment out (or delete) https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/home/home_view.js#L88 from OuiFlexItem to the close and this solves the problem as well

@ananzh
Clean Homepage
9fca4ec 
Issue Resolved:
opensearch-project#255

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh
Copy link
Member Author

ananzh commented Feb 22, 2023

Otherwise instead of changing the file you can actually just comment out (or delete) https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/home/home_view.js#L88 from OuiFlexItem to the close and this solves the problem as well

I kept the home_illustration.tsx and remove the whole OuiFlexItem.

@KrooshalUX
Copy link
Contributor

Otherwise instead of changing the file you can actually just comment out (or delete) https://github.com/opensearch-project/oui/blob/main/src-docs/src/views/home/home_view.js#L88 from OuiFlexItem to the close and this solves the problem as well

I kept the home_illustration.tsx and remove the whole OuiFlexItem.

We can get rid of the home_illustration.tsx, I am not planning to provide a replacement and this is not our original artwork.

seanneumann
seanneumann approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seanneumann seanneumann merged commit d072d82 into opensearch-project:main Feb 27, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 27, 2023
@ananzh @github-actions
Clean Homepage (#500)
c8e0e1a 
Issue Resolved:
#255

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit d072d82)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 27, 2023
Merged
seanneumann added a commit that referenced this pull request Feb 28, 2023
@opensearch-trigger-bot @ananzh @seanneumann
Clean Homepage (#500) (#524)
e650486 
Issue Resolved:
#255

Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit d072d82)

Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
@KrooshalUX KrooshalUX mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrooshalUX KrooshalUX KrooshalUX left review comments

@kavilla kavilla kavilla approved these changes

@seanneumann seanneumann seanneumann approved these changes

Assignees

@ananzh ananzh

Labels
backport 1.0 OUIDocs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(OUI Docs Site) Homepage
4 participants
@ananzh @kavilla @KrooshalUX @seanneumann