Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUI Docs] Updated the section Beacon #367

Merged

Conversation

AbhishekReddy1127
Copy link
Contributor

@AbhishekReddy1127 AbhishekReddy1127 commented Feb 21, 2023

Description

Updated the section Beacon.
Screenshot 2023-02-28 at 11 34 20 AM

Issues Resolved

#340

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AbhishekReddy1127 AbhishekReddy1127 marked this pull request as ready for review February 21, 2023 17:54
@AbhishekReddy1127 AbhishekReddy1127 requested a review from a team as a code owner February 21, 2023 17:54
@KrooshalUX KrooshalUX linked an issue Feb 21, 2023 that may be closed by this pull request
1 task
@KrooshalUX
Copy link
Contributor

Nit: add space between the callout and the text "Use the OUIBeacon..."

Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add space between the callout and the text "Use the OUIBeacon..."

@AbhishekReddy1127 AbhishekReddy1127 self-assigned this Feb 21, 2023
@AbhishekReddy1127 AbhishekReddy1127 force-pushed the OUI_Docs_Beacon branch 3 times, most recently from 6fb3787 to e9895a1 Compare February 27, 2023 04:08
BSFishy
BSFishy previously approved these changes Feb 27, 2023
seanneumann
seanneumann previously approved these changes Feb 27, 2023
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BSFishy BSFishy requested a review from KrooshalUX February 27, 2023 21:55
@seanneumann seanneumann dismissed their stale review February 28, 2023 01:50

Let's get the other request from Kroosh in.

@AbhishekReddy1127
Copy link
Contributor Author

Nit: add space between the callout and the text "Use the OUIBeacon..."

Updated

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: AbhishekReddy1127 <[email protected]>
Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seanneumann seanneumann merged commit fb2a386 into opensearch-project:main Feb 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2023
* Updated the section Beacon

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the page

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the page

Signed-off-by: AbhishekReddy1127 <[email protected]>

---------

Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit fb2a386)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2023
* Updated the section Beacon

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the page

Signed-off-by: AbhishekReddy1127 <[email protected]>

* Updated the page

Signed-off-by: AbhishekReddy1127 <[email protected]>

---------

Signed-off-by: AbhishekReddy1127 <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit fb2a386)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BSFishy pushed a commit that referenced this pull request May 9, 2023
* Updated the section Beacon



* Updated the page



* Updated the page



---------



(cherry picked from commit fb2a386)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <[email protected]>
ashwin-pc pushed a commit that referenced this pull request May 25, 2023
* Updated the section Beacon



* Updated the page



* Updated the page



---------



(cherry picked from commit fb2a386)

Signed-off-by: AbhishekReddy1127 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(OUI Docs) Beacon
4 participants