Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update callout docs #253

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Jan 24, 2023

Signed-off-by: Matt Provost provomat@amazon.com

Description

Update docs for callout to match the changes prescribed in the issue

2023-02-01 14_54_04-Callout - OpenSearch UI Framework
2023-02-01 14_54_12-wip flp - FL Studio 21

Issues Resolved

#241

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>
@BSFishy BSFishy requested a review from a team as a code owner January 24, 2023 21:35
@BSFishy BSFishy self-assigned this Jan 24, 2023
@BSFishy BSFishy linked an issue Jan 24, 2023 that may be closed by this pull request
6 tasks
@BSFishy BSFishy requested a review from KrooshalUX January 24, 2023 22:21
Copy link
Contributor

@KrooshalUX KrooshalUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seanneumann seanneumann merged commit 905582a into opensearch-project:main Feb 27, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 27, 2023
Signed-off-by: Matt Provost <provomat@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
(cherry picked from commit 905582a)
seanneumann pushed a commit that referenced this pull request Feb 28, 2023
Signed-off-by: Matt Provost <provomat@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
(cherry picked from commit 905582a)

Co-authored-by: Matt Provost <provomat@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(OUI Docs) Callout
4 participants