-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration test workflows #1075
Merged
joshuarrrr
merged 10 commits into
opensearch-project:main
from
BSFishy:fix/integ-workflow
Nov 14, 2023
Merged
Fix integration test workflows #1075
joshuarrrr
merged 10 commits into
opensearch-project:main
from
BSFishy:fix/integ-workflow
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSFishy
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
October 12, 2023 16:33
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
BSFishy
force-pushed
the
fix/integ-workflow
branch
from
October 12, 2023 20:39
95e0dd9
to
e554c13
Compare
Signed-off-by: Matt Provost <[email protected]>
Most integ tests are expected to fail until #1062 is merged |
BSFishy
commented
Oct 12, 2023
Comment on lines
-218
to
-220
defaults: | ||
run: | ||
working-directory: ./artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an artifact of my original implementation, which I simply forgot to take out before merging :P
AMoo-Miki
approved these changes
Oct 12, 2023
joshuarrrr
previously approved these changes
Oct 12, 2023
joshuarrrr
approved these changes
Oct 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Extract build archive into folder Signed-off-by: Matt Provost <[email protected]> * Runtime check of value Signed-off-by: Matt Provost <[email protected]> * Remove cache for OSD integ Signed-off-by: Matt Provost <[email protected]> * Reordered steps Signed-off-by: Matt Provost <[email protected]> * Remove OSD build from hoisted directory Signed-off-by: Matt Provost <[email protected]> * Minor cleanup Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 3476394) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
joshuarrrr
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Extract build archive into folder Signed-off-by: Matt Provost <[email protected]> * Runtime check of value Signed-off-by: Matt Provost <[email protected]> * Remove cache for OSD integ Signed-off-by: Matt Provost <[email protected]> * Reordered steps Signed-off-by: Matt Provost <[email protected]> * Remove OSD build from hoisted directory Signed-off-by: Matt Provost <[email protected]> * Minor cleanup Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 3476394) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There seems to be some issues with OSD consuming a tarball archive as a dependency instead of a directory. This is meant to fix that and extract the build archive.
This PR does:
Check List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.