Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test workflows #1075

Merged
merged 10 commits into from
Nov 14, 2023

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Oct 12, 2023

Description

There seems to be some issues with OSD consuming a tarball archive as a dependency instead of a directory. This is meant to fix that and extract the build archive.

This PR does:

  • Remove caching in OSD integration tests. This makes sure each commit the workflow will pull from the latest build instead of using a cached one
  • Extract build archive into a folder. The theory is that OSD processes this better
  • Remove hoisting of the working directory in the OSD build jobs. Otherwise, the hoisting of the working directory would break the build for some reason

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
@BSFishy BSFishy force-pushed the fix/integ-workflow branch from 95e0dd9 to e554c13 Compare October 12, 2023 20:39
Signed-off-by: Matt Provost <[email protected]>
@BSFishy
Copy link
Contributor Author

BSFishy commented Oct 12, 2023

Most integ tests are expected to fail until #1062 is merged

Comment on lines -218 to -220
defaults:
run:
working-directory: ./artifacts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an artifact of my original implementation, which I simply forgot to take out before merging :P

joshuarrrr
joshuarrrr previously approved these changes Oct 12, 2023
@joshuarrrr joshuarrrr dismissed their stale review October 16, 2023 22:39

CI doesn't yet pass

@joshuarrrr joshuarrrr merged commit 3476394 into opensearch-project:main Nov 14, 2023
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 14, 2023
* Extract build archive into folder

Signed-off-by: Matt Provost <[email protected]>

* Runtime check of value

Signed-off-by: Matt Provost <[email protected]>

* Remove cache for OSD integ

Signed-off-by: Matt Provost <[email protected]>

* Reordered steps

Signed-off-by: Matt Provost <[email protected]>

* Remove OSD build from hoisted directory

Signed-off-by: Matt Provost <[email protected]>

* Minor cleanup

Signed-off-by: Matt Provost <[email protected]>

* Update changelog

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 3476394)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr pushed a commit that referenced this pull request Nov 14, 2023
* Extract build archive into folder

Signed-off-by: Matt Provost <[email protected]>

* Runtime check of value

Signed-off-by: Matt Provost <[email protected]>

* Remove cache for OSD integ

Signed-off-by: Matt Provost <[email protected]>

* Reordered steps

Signed-off-by: Matt Provost <[email protected]>

* Remove OSD build from hoisted directory

Signed-off-by: Matt Provost <[email protected]>

* Minor cleanup

Signed-off-by: Matt Provost <[email protected]>

* Update changelog

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 3476394)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants