Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes route prefix setting routeNamePrefix optional #868

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESIGN.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Extensions are registered through the below REST request within OpenSearch.

```bash
curl -XPOST "localhost:9200/_extensions/initialize" -H "Content-Type:application/json" --data '{ \
"name":"hello-world", \ // extension name
"name":"helloWorld", \ // extension name
"uniqueId":"hello-world", \ // identifier for the extension
"hostAddress":"127.0.0.1", \ // host address
"port":"4532", \ // port number
Expand Down
6 changes: 3 additions & 3 deletions DEVELOPER_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ To **run OpenSearch from a compiled binary**, follow these steps:
- Send the below sample REST API to initialize an extension
```bash
curl -XPOST "localhost:9200/_extensions/initialize" -H "Content-Type:application/json" --data '{
"name":"hello-world",
"name":"helloWorld",
"uniqueId":"hello-world",
"hostAddress":"127.0.0.1",
"port":"4532",
Expand All @@ -163,7 +163,7 @@ To **run OpenSearch from Gradle**, follow these steps:
- Send the below sample REST API to initialize an extension
```bash
curl -XPOST "localhost:9200/_extensions/initialize" -H "Content-Type:application/json" --data '{
"name":"hello-world",
"name":"helloWorld",
"uniqueId":"hello-world",
"hostAddress":"127.0.0.1",
"port":"4532",
Expand Down Expand Up @@ -296,7 +296,7 @@ tar -xvf opensearch-sdk-java-1.0.0-SNAPSHOT.tar
The artifact will include extension settings for the sample Hello World extension on the class path under the path `/sample/extension-settings.yml`:

```yaml
extensionName: hello-world
extensionName: helloWorld
hostAddress: 127.0.0.1
hostPort: 4532
opensearchAddress: 127.0.0.1
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/sample/helloworld-settings.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
extensionName: hello-world
extensionName: helloWorld
hostAddress: 127.0.0.1
hostPort: 4500
opensearchAddress: 127.0.0.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public void tearDown() throws Exception {
public void testExtensionSettings() {
// This effectively tests the Extension interface helper method
ExtensionSettings extensionSettings = extension.getExtensionSettings();
ExtensionSettings expected = new ExtensionSettings("hello-world", "127.0.0.1", "4532", "127.0.0.1", "9200");
ExtensionSettings expected = new ExtensionSettings("helloWorld", "127.0.0.1", "4532", "127.0.0.1", "9200");
assertEquals(expected.getExtensionName(), extensionSettings.getExtensionName());
assertEquals(expected.getHostAddress(), extensionSettings.getHostAddress());
assertEquals(expected.getHostPort(), extensionSettings.getHostPort());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class TestRestHelloAction extends OpenSearchTestCase {

private ExtensionRestHandler restHelloAction;
// Temporarily removed pending integration of feature/identity branch
// private static final String EXTENSION_NAME = "hello-world";
// private static final String EXTENSION_NAME = "helloWorld";

@Override
@BeforeEach
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/hello-world-extension.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: hello-world
name: helloWorld
uniqueId: opensearch-sdk-java-1
hostAddress: '127.0.0.1'
port: '4500'
Expand Down