[Backport 1.x] Added support for headers for ExtensionRestRequest #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* added uri and httpVersion to HttpRequest Signed-off-by: Daulet <[email protected]> * added SDKHttpRequest, SDKRestRequest Signed-off-by: Daulet <[email protected]> * spotless applied Signed-off-by: Daulet <[email protected]> * moved SDKHttpRequest and SDKRestRequest to org.opensearch.sdk.rest Signed-off-by: Daulet <[email protected]> * tests changed for new ExtensionRestRequest Signed-off-by: Daulet <[email protected]> * TestSDKRestRequest created Signed-off-by: Daulet <[email protected]> * corrected test for xContentType, added test for contentParser() Signed-off-by: Daulet <[email protected]> * replaced .map() with mapStrings() in contentParser() Signed-off-by: Daulet <[email protected]> * Update SDKHttpRequest.java Signed-off-by: Daulet Nassipkali <[email protected]> * Fix tests for new format Signed-off-by: Daniel Widdis <[email protected]> * Use correct Test annotation so tests actually run Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daulet <[email protected]> Signed-off-by: Daulet Nassipkali <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> (cherry picked from commit dfdb050) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
joshpalis,
owaiskazi19,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
|
And the workflow started working again! |
owaiskazi19
approved these changes
Apr 7, 2023
|
Gradle check failing until 2.x backport of companion PR is merged: opensearch-project/OpenSearch#7055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport dfdb050 from #643.