Changed the test for RegexValidator class #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuanysh-kst
requested review from
joshpalis,
owaiskazi19,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
dbwiddis
requested changes
Mar 25, 2023
src/test/java/org/opensearch/sdk/sample/helloworld/TestHelloWorldExtension.java
Show resolved
Hide resolved
Kuanysh-kst
commented
Mar 26, 2023
src/test/java/org/opensearch/sdk/sample/helloworld/TestHelloWorldExtension.java
Outdated
Show resolved
Hide resolved
Kuanysh-kst
force-pushed
the
testchanges
branch
from
98882a1 to
ffbf74c
Compare
Kuanysh-kst
commented
Mar 26, 2023
src/main/java/org/opensearch/sdk/sample/helloworld/ExampleCustomSettingConfig.java
Outdated
Show resolved
Hide resolved
Kuanysh-kst
commented
Mar 26, 2023
src/main/java/org/opensearch/sdk/sample/helloworld/ExampleCustomSettingConfig.java
Outdated
Show resolved
Hide resolved
dbwiddis
reviewed
Mar 26, 2023
src/main/java/org/opensearch/sdk/sample/helloworld/ExampleCustomSettingConfig.java
Outdated
Show resolved
Hide resolved
dbwiddis
requested changes
Mar 29, 2023
src/main/java/org/opensearch/sdk/sample/helloworld/ExampleCustomSettingConfig.java
Outdated
Show resolved
Hide resolved
Kuanysh-kst
commented
Mar 30, 2023
src/test/java/org/opensearch/sdk/sample/helloworld/TestHelloWorldExtension.java
Outdated
Show resolved
Hide resolved
dbwiddis
previously approved these changes
Apr 5, 2023
ryanbogan
previously approved these changes
Apr 6, 2023
|
@Kuanysh-kst Looks like gradle check is failing. Please rebase your PR with SDK main |
The failure is the signature of the class just merged in companion PR. May need to wait for snapshot publishing. |
Snapshot has been published: https://github.com/opensearch-project/OpenSearch/actions/runs/4639883181. Updated the |
|
Build is failing because of: |
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Signed-off-by: Kuanysh <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #608 +/- ##
============================================
+ Coverage 64.08% 64.17% +0.08%
- Complexity 268 269 +1
============================================
Files 54 54
Lines 1150 1150
Branches 35 35
============================================
+ Hits 737 738 +1
+ Misses 402 401 -1
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
approved these changes
Apr 7, 2023
ryanbogan
approved these changes
Apr 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
* Created the MapperExtension interface and added the MapperPlugin content Signed-off-by: Kuanysh <[email protected]> * deleted comments Signed-off-by: Kuanysh <[email protected]> * add javadoc Signed-off-by: Kuanysh <[email protected]> * add unit test Signed-off-by: Kuanysh <[email protected]> * refactor for unit test Signed-off-by: Kuanysh <[email protected]> * fix bugs Signed-off-by: Kuanysh <[email protected]> * code refactoring Signed-off-by: Kuanysh <[email protected]> * change test Signed-off-by: Kuanysh <[email protected]> * code refactoring Signed-off-by: Kuanysh <[email protected]> * shortened the code Signed-off-by: Kuanysh <[email protected]> * add false parametr Signed-off-by: Kuanysh <[email protected]> * code rafactoring Signed-off-by: Kuanysh <[email protected]> * Remove stray file from old commit that survived rebase Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Kuanysh <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Daniel Widdis <[email protected]> (cherry picked from commit a7a8164) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
added a commit
that referenced
this pull request
Apr 11, 2023
* Created the MapperExtension interface and added the MapperPlugin content * deleted comments * add javadoc * add unit test * refactor for unit test * fix bugs * code refactoring * change test * code refactoring * shortened the code * add false parametr * code rafactoring * Remove stray file from old commit that survived rebase --------- (cherry picked from commit a7a8164) Signed-off-by: Kuanysh <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Widdis <[email protected]> Co-authored-by: Owais Kazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I am refactoring the test so that it passes, this PR is related to this PR: opensearch-project/OpenSearch#6823
Issues Resolved
#591
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.