Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial draft of Design for extensions #60

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Initial draft of Design for extensions #60

merged 6 commits into from
Jul 29, 2022

Conversation

saratvemulapalli
Copy link
Member

Signed-off-by: Sarat Vemulapalli [email protected]

Description

Initial Draft of design for extensions

Issues Resolved

#35

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saratvemulapalli
Initial draft of Design for extensions
c9f6eac 
Signed-off-by: Sarat Vemulapalli <[email protected]>
@saratvemulapalli
Adding TBD sections
cccd4bc 
Signed-off-by: Sarat Vemulapalli <[email protected]>
@saratvemulapalli saratvemulapalli requested a review from a team July 25, 2022 17:08
peternied
peternied reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up!

DESIGN.md Show resolved Hide resolved
DESIGN.md Show resolved Hide resolved
DESIGN.md Outdated Show resolved Hide resolved
DESIGN.md Outdated Show resolved Hide resolved
DESIGN.md Outdated Show resolved Hide resolved
DESIGN.md Outdated Show resolved Hide resolved
minalsha
minalsha reviewed Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@minalsha minalsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for kicking this design for extensions doc. Added comments

owaiskazi19
owaiskazi19 reviewed Jul 25, 2022
View reviewed changes
DESIGN.md Show resolved Hide resolved
owaiskazi19
owaiskazi19 reviewed Jul 25, 2022
View reviewed changes
DESIGN.md Outdated Show resolved Hide resolved
owaiskazi19
owaiskazi19 reviewed Jul 25, 2022
View reviewed changes
DESIGN.md Show resolved Hide resolved
owaiskazi19
owaiskazi19 reviewed Jul 25, 2022
View reviewed changes
DESIGN.md Outdated Show resolved Hide resolved
owaiskazi19
owaiskazi19 reviewed Jul 25, 2022
View reviewed changes
DESIGN.md Outdated Show resolved Hide resolved
@owaiskazi19
Added communcation, sdk and latency
f23c93d 
Signed-off-by: Owais Kazi <[email protected]>
@owaiskazi19
Lint errors
a2cdb7d 
Signed-off-by: Owais Kazi <[email protected]>
saratvemulapalli
saratvemulapalli commented Jul 26, 2022
View reviewed changes
DESIGN.md Outdated Show resolved Hide resolved
@owaiskazi19
Moved Latency to FAQ
2cc77ab 
Signed-off-by: Owais Kazi <[email protected]>
@saratvemulapalli
Copy link
Member Author

@owaiskazi19 your force push cleaned up my changes.
For next time, do a rebase and then push your changes :)

I didnt realize until @peternied asked :)

peternied
peternied reviewed Jul 26, 2022
View reviewed changes
DESIGN.md Show resolved Hide resolved
DESIGN.md Outdated Show resolved Hide resolved
DESIGN.md Show resolved Hide resolved
@saratvemulapalli
Readdressing comments
2b17fe1 
Signed-off-by: Sarat Vemulapalli <[email protected]>
peternied
peternied reviewed Jul 26, 2022
View reviewed changes
DESIGN.md Show resolved Hide resolved
peternied
peternied reviewed Jul 26, 2022
View reviewed changes
DESIGN.md Show resolved Hide resolved
peternied
peternied reviewed Jul 26, 2022
View reviewed changes
DESIGN.md Show resolved Hide resolved
@owaiskazi19
Copy link
Member

@owaiskazi19 your force push cleaned up my changes. For next time, do a rebase and then push your changes :)

I didnt realize until @peternied asked :)

My bad. Did you push those changes or should I take care of it?

@saratvemulapalli
Copy link
Member Author

@owaiskazi19 your force push cleaned up my changes. For next time, do a rebase and then push your changes :)
I didnt realize until @peternied asked :)

My bad. Did you push those changes or should I take care of it?

I did, dont worry.

peternied
peternied reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a couple of unresolved conversations, @saratvemulapalli @owaiskazi19 did you have any outstanding questions?

@owaiskazi19
Copy link
Member

It looks like there are a couple of unresolved conversations, @saratvemulapalli @owaiskazi19 did you have any outstanding questions?

I have one here

@saratvemulapalli saratvemulapalli mentioned this pull request Jul 28, 2022
Closed
@saratvemulapalli saratvemulapalli merged commit f9b3157 into opensearch-project:main Jul 29, 2022
@dbwiddis dbwiddis mentioned this pull request Jul 30, 2022
Closed
dbwiddis
dbwiddis reviewed Jul 30, 2022
View reviewed changes
DESIGN.md

### Settings
Walking through a similar example as plugin above, after extension registration is done, extension makes an API call to register custom settings to OpenSearch.
`ExtensionsOrchestrator` receives the requests, forwards it to `SettingsModule` to register a new setting and wala, the user is now able to toggle the setting via `_settings` Rest API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/wala/voilà/

This was referenced Jul 30, 2022
Closed
Closed
This was referenced Aug 26, 2022
Merged
Open
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
@saratvemulapalli @owaiskazi19 @kokibas
Initial draft of Design for extensions (opensearch-project#60)
842fae4 
* Initial draft of Design for extensions

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Adding TBD sections

Signed-off-by: Sarat Vemulapalli <[email protected]>

* Added communcation, sdk and latency

Signed-off-by: Owais Kazi <[email protected]>

* Lint errors

Signed-off-by: Owais Kazi <[email protected]>

* Moved Latency to FAQ

Signed-off-by: Owais Kazi <[email protected]>

* Readdressing comments

Signed-off-by: Sarat Vemulapalli <[email protected]>

Co-authored-by: Owais Kazi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis left review comments

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@peternied peternied peternied approved these changes

@minalsha minalsha Awaiting requested review from minalsha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saratvemulapalli @owaiskazi19 @peternied @dbwiddis @minalsha