-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for minimum compatible version for Extensions and OpenSearch #365
Merged
dbwiddis
merged 5 commits into
opensearch-project:main
from
saratvemulapalli:versioning-sdk
Feb 2, 2023
Merged
Add support for minimum compatible version for Extensions and OpenSearch #365
dbwiddis
merged 5 commits into
opensearch-project:main
from
saratvemulapalli:versioning-sdk
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
saratvemulapalli
changed the title
Trim down extensions config
Add support for minimum compatible version for Extensions and OpenSearch
Jan 27, 2023
saratvemulapalli
requested review from
CEHENKLE,
joshpalis,
owaiskazi19,
ryanbogan and
dbwiddis
as code owners
January 27, 2023 23:42
dbwiddis
reviewed
Jan 28, 2023
Signed-off-by: Sarat Vemulapalli <[email protected]>
dbwiddis
previously approved these changes
Jan 31, 2023
ryanbogan
previously approved these changes
Jan 31, 2023
Looks like gradle check is failing |
Needs companion PR merged first. |
Signed-off-by: Sarat Vemulapalli <[email protected]>
saratvemulapalli
dismissed stale reviews from ryanbogan and dbwiddis
via
February 1, 2023 18:24
b9dc18a
The last snapshot published is on Jan 31[1]. Still waiting for the latest changes in maven. |
ryanbogan
approved these changes
Feb 2, 2023
dbwiddis
approved these changes
Feb 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
…rch (#365) * Updating extensions config file Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating with new ExtensionNode class def Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating docs Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding more changes Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]> (cherry picked from commit 1e9dc4e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ryanbogan
pushed a commit
that referenced
this pull request
Feb 2, 2023
…rch (#365) (#399) * Updating extensions config file * Updating with new ExtensionNode class def * Updating docs * Addressing comments * Adding more changes --------- (cherry picked from commit 1e9dc4e) Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…rch (opensearch-project#365) * Updating extensions config file Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating with new ExtensionNode class def Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating docs Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]> * Adding more changes Signed-off-by: Sarat Vemulapalli <[email protected]> --------- Signed-off-by: Sarat Vemulapalli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarat Vemulapalli [email protected]
Description
Complementing PR to: opensearch-project/OpenSearch#6003
Marking this as draft, while working on #346.
Issues Resolved
Closes #65
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.