Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding maven Snapshots repo for SDK #311

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

saratvemulapalli
Copy link
Member

Signed-off-by: Sarat Vemulapalli [email protected]

Description

Adding snapshots maven publish to publishing tasks.

Publishing tasks
----------------
generateMetadataFileForMavenJavaPublication - Generates the Gradle metadata file for publication 'mavenJava'.
generatePomFileForMavenJavaPublication - Generates the Maven POM file for publication 'mavenJava'.
publish - Publishes all publications produced by this project.
publishAllPublicationsToSnapshotsRepository - Publishes all Maven publications produced by this project to the Snapshots repository.
publishMavenJavaPublicationToMavenLocal - Publishes Maven publication 'mavenJava' to the local Maven repository.
publishMavenJavaPublicationToSnapshotsRepository - Publishes Maven publication 'mavenJava' to Maven repository 'Snapshots'.
publishToMavenLocal - Publishes all Maven publications produced by this project to the local Maven cache.

Issues Resolved

Part of #92

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sarat Vemulapalli <[email protected]>
@saratvemulapalli
Copy link
Member Author

cc: @gaiksaya

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #311 (f5ca4d4) into main (7ceebb7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #311   +/-   ##
=========================================
  Coverage     72.97%   72.97%           
  Complexity      120      120           
=========================================
  Files            25       25           
  Lines           518      518           
  Branches         15       15           
=========================================
  Hits            378      378           
  Misses          131      131           
  Partials          9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaiksaya
Copy link
Member

gaiksaya commented Jan 9, 2023

Posting the query here as well. I see 2 different group id in build.gradle

group 'org.opensearch.sdk'
version '1.0.0-SNAPSHOT'
publishing {
publications {
group = "org.opensearch"
version = "1.0.0-SNAPSHOT"

Please confirm the what should be the right group id. Thanks!

> Task :publishMavenJavaPublicationToSnapshotsRepository FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':publishMavenJavaPublicationToSnapshotsRepository'.
> Failed to publish publication 'mavenJava' to repository 'Snapshots'
   > Could not PUT 'https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch-sdk-java/1.0.0-SNAPSHOT/maven-metadata.xml'. Received status code 401 from server: Unauthorized

dbwiddis
dbwiddis previously approved these changes Jan 9, 2023
build.gradle Outdated Show resolved Hide resolved
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saratvemulapalli saratvemulapalli merged commit 0ce8a0d into opensearch-project:main Jan 10, 2023
@saratvemulapalli saratvemulapalli deleted the snapshots branch January 10, 2023 02:07
kokibas pushed a commit to kokibas/opensearch-sdk-java that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants