-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Renovate #256
Configure Renovate #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move this to .github
directory and tweak the config later this week.
66aea34
to
3ca6b49
Compare
3ca6b49
to
19f51af
Compare
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
=========================================
Coverage 72.79% 72.79%
Complexity 128 128
=========================================
Files 28 28
Lines 566 566
Branches 16 16
=========================================
Hits 412 412
Misses 145 145
Partials 9 9 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@dbwiddis do we have any issue for Renovate? Just trying to understand what does it do differently than dependabot? Also, we need to add DCO check for it. |
I tried to force-push with a DCO but then it force pushed over my force push! I'll try another tactic tonight. As for what it does differently:
|
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
19f51af
to
d79a703
Compare
@owaiskazi19 this was originally requested in #185 but took a while to get approved. See the comments on that issue for why I think it's a better choice than dependabot (which I will remove in a separate PR once this is merged). See also opensearch-project/.github#97 where I will eventually outline this as one of two good options for dependency management that repos should consider.
At its core it does "the same thing" but having run both side by side on my own project during transition:
|
One other thing I really like is that the PRs have a status on % adoption and % passing tests from others who have merged the update. When there is (rarely) a breaking change in a plugin that causes everyone's tests to fail, this will catch it and help you avoid (or at least quickly identify that you are not alone) the inevitable test failures. |
Signed-off-by: Daniel Widdis <[email protected]>
Thanks @dbwiddis for bringing this up. I didn't know Renovate has better advantages than dependabot. One last thing we need to do is to add the DCO check for Renovate. Should we do it as a part of this PR or open an issue for the same? |
It is a subjective opinion. For us it's less important; I really think the main project needs this and having it here will give them something to look at as a demo.
Added the
Already added to this PR in 132a30a |
Signed-off-by: Daniel Widdis <[email protected]>
Missed this. |
Renovate is disabledRenovate is disabled because there is no Renovate configuration file. To enable Renovate, you can either (a) change this PR's title to get a new onboarding PR, and merge the new onboarding PR, or (b) create a Renovate config file, and commit that file to your base branch. |
* Add renovate.json Signed-off-by: Daniel Widdis <[email protected]> * Move Renovate to .github and preemptively update some versions Signed-off-by: Daniel Widdis <[email protected]> * Remove dependabot since it would be redundant Signed-off-by: Daniel Widdis <[email protected]> * Explicitly add git signoff (Co-authored-by passes DCO) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Daniel Widdis <[email protected]> Co-authored-by: Daniel Widdis <[email protected]>
Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.
Detected Package Files
.github/workflows/build.yml
(github-actions).github/workflows/wrapper.yml
(github-actions)gradle.properties
(gradle)settings.gradle
(gradle)build.gradle
(gradle)gradle/formatting.gradle
(gradle)gradle/wrapper/gradle-wrapper.properties
(gradle-wrapper)Configuration
🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.
Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.
What to Expect
With your current configuration, Renovate will create 7 Pull Requests:
Update codecov/codecov-action action to v3.1.1
renovate/codecov-codecov-action-3.x
main
v3.1.1
Update dependency org.apache.lucene:lucene-core to v9.4.2
renovate/luceneversion
main
9.4.2
Update jacksonDatabindVersion to v2.14.1
renovate/jacksondatabindversion
main
2.14.1
2.14.1
2.14.1
2.14.1
Update dependency gradle to v7.6
renovate/gradle-7.x
main
7.6
Update plugin com.diffplug.spotless to v6.12.0
renovate/com.diffplug.spotless-6.x
main
6.12.0
Update actions/checkout action to v3
renovate/actions-checkout-3.x
main
v3
Update actions/setup-java action to v3
renovate/actions-setup-java-3.x
main
v3
🚸 Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or spam the project. See docs for
prhourlylimit
for details.❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.
This PR has been generated by Mend Renovate. View repository job log here.