-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Netty Logging to only display errors and default logging to debug #181
Updating Netty Logging to only display errors and default logging to debug #181
Conversation
Signed-off-by: Sarat Vemulapalli <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
============================================
+ Coverage 66.00% 66.94% +0.93%
- Complexity 96 103 +7
============================================
Files 25 24 -1
Lines 456 475 +19
Branches 13 25 +12
============================================
+ Hits 301 318 +17
+ Misses 147 141 -6
- Partials 8 16 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd even be happy with INFO level logging, with instructions how to change it in the developer guide.
+1 We'll start with debug and we could move over to info eventually overtime. |
Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Sarat Vemulapalli <[email protected]> Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Sarat Vemulapalli [email protected]
Description
Updating Netty logging to only print out errors.
Netty is using reflective access which is denied by default for Java > 8.
See: netty/netty#7817
As recommendation says, its just a warning but its not fatal problems for the application. For SDK we really dont care about Netty debug/trace logs, error should be good enough.
This PR also updates default logging to debug as trace is not really helping a human unless we really want to debug core problems.
Issues Resolved
Closes #180
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.