Transport service

[mloufra]

Description

To avoid passing the object of extensionRunner in ExtensionsRunner main function, move all of the required methods and variables to NettyTransport file
Address comment from previous PR.

Issues Resolved

#166
#116

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #170 (42f5281) into main (8fbcc6e) will increase coverage by 0.43%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main     #170      +/-   ##
============================================
+ Coverage     66.00%   66.44%   +0.43%     
  Complexity       96       96              
============================================
  Files            25       25              
  Lines           456      456              
  Branches         13       12       -1     
============================================
+ Hits            301      303       +2     
+ Misses          147      146       -1     
+ Partials          8        7       -1     

Impacted Files	Coverage Δ
...main/java/org/opensearch/sdk/ExtensionsRunner.java	63.23% <50.00%> (ø)
...c/main/java/org/opensearch/sdk/NettyTransport.java	100.00% <100.00%> (+7.14%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dbwiddis]

Code changes look good. Just need some doc fixes on the constructor javadoc.

[dbwiddis]

Fixed the bind errors by moving the netty initialization out of the constructor in the Extensions Runner and backed out the "hack" solution from intervening PR. The rest is what was ready to go before this weekend and is GTG now! :)

[dbwiddis]

@ryanbogan can you help resolve the conflicts of this PR with #146 which was recently merged? Build is failing on the additional arguments to new NettyTransport(runner).initializeExtensionTransportService(runner.getSettings());

[ryanbogan]

That method should take a threadPool parameter too. Adding that will let the compile check pass

[ryanbogan]

I can't access the branch with the changes for some reason. The only branch I see on @mloufra 's fork is main.

[mloufra]

I can't access the branch with the changes for some reason. The only branch I see on @mloufra 's fork is main.

I fork our sdk repo again this morning. That's why only main branch in my fork repo.

[owaiskazi19]

I fork our sdk repo again this morning. That's why only main branch in my fork repo.

@mloufra you should close this PR and raise again with the new fork repo as you won't be able to access transportService branch anymore on your fork.

[mloufra]

I fork our sdk repo again this morning. That's why only main branch in my fork repo.

@mloufra you should close this PR and raise again with the new fork repo as you won't be able to access transportService branch anymore on your fork.

Thanks.