[Feature/extensions] Adding support for Extension Create Components [environment settings and add setting update consumers] #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
6 tasks
…tion Signed-off-by: Joshua Palis <[email protected]>
…rectly from setting update consumer registry Signed-off-by: Joshua Palis <[email protected]>
joshpalis
changed the title
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
dbwiddis
previously approved these changes
Sep 20, 2022
| Object data = updateSettingsRequest.getData(); | ||
|
|
||
| // Setting updater in OpenSearch performs setting change validation, only need to cast the consumer to the corresponding type and | ||
| // invoke the consumer |
There was a problem hiding this comment.
Not a request to change anything in your PR but a note for awareness. The original validator and parser are lost in the existing setup, so if there was some extra validation step (for example, minimum value integer) it might not properly validate on the OpenSearch side. That's fine for now as it will eventually be handled by #154.
owaiskazi19
reviewed
Sep 23, 2022
Signed-off-by: Joshua Palis <[email protected]>
owaiskazi19
reviewed
Sep 23, 2022
…eanResponseHandler, moving handleUpdateSettings method to seperate class Signed-off-by: Joshua Palis <[email protected]>
…will only need to provide a map of setting and consumer, and upon sending the addsettingupdateconsumer request, this map will be registered within the updateSettingsRequestHandler Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
dbwiddis
approved these changes
Sep 24, 2022
ryanbogan
approved these changes
Sep 26, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…environment settings and add setting update consumers] (opensearch-project#138) * Added support for enviornment settings requests and unit tests Signed-off-by: Joshua Palis <[email protected]> * updated environment settings support for create components Signed-off-by: Joshua Palis <[email protected]> * Updating javadocs for environmentsetting request/ response handlers Signed-off-by: Joshua Palis <[email protected]> * Adding inital support for AddSettingsUpdateConsumer Signed-off-by: Joshua Palis <[email protected]> * Updated implementation in preparation for getSettings support integration Signed-off-by: Joshua Palis <[email protected]> * Updated sendAddSettingsUpdateConsumerRequest to pull settings list directly from setting update consumer registry Signed-off-by: Joshua Palis <[email protected]> * Integrated writeable settings support Signed-off-by: Joshua Palis <[email protected]> * Updating writeable settings integration for setting type Signed-off-by: Joshua Palis <[email protected]> * Replacing AddSettingsUpdateConsumerResponseHandler with ExtensionBooleanResponseHandler, moving handleUpdateSettings method to seperate class Signed-off-by: Joshua Palis <[email protected]> * refactoring sendAddSettingsUpdateConsumerRequest. Now each component will only need to provide a map of setting and consumer, and upon sending the addsettingupdateconsumer request, this map will be registered within the updateSettingsRequestHandler Signed-off-by: Joshua Palis <[email protected]> * simplifying settingUpdateConsumer registration Signed-off-by: Joshua Palis <[email protected]> * Fixing javadocs Signed-off-by: Joshua Palis <[email protected]> * fixing javadocs Signed-off-by: Joshua Palis <[email protected]> * adding missing javadocs Signed-off-by: Joshua Palis <[email protected]> * fixing javadocs Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: Joshua Palis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for extensions to request environment setting values from opensearch, to add setting update consumers to cluster settings, and to receive update setting requests from Opensearch whenever a setting is updated.
Companion PR : opensearch-project/OpenSearch#4517
Note : Currently in a draft state until #79 is resolved
Issues Resolved
#78
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.