-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage #104
Code coverage #104
Conversation
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
@mloufra can you link an example of the codecov report being published as a PR Comment? |
I will try to make one today |
Failure in build:
|
Signed-off-by: mloufra <[email protected]>
Signed-off-by: mloufra <[email protected]>
The unknown command-line option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it to see if codecov will work once codecov.yml
is in. We can always revert this change if it doesn’t :)
I agree with this idea. Let me explain little more about what's going on. For now, We are able to generate the code coverage report for our branch, and push the report to |
I like our report and the badge that gets us quickly to it! Will really help us audit our code coverage. |
The Codecov comment is running successfully. Here is the link. |
Glad it was my awesome well-covered PR that proves it's working. 😀 |
* issue opensearch-project#28 Signed-off-by: mloufra <[email protected]> * Update the lastest coomit Signed-off-by: mloufra <[email protected]> * Rename the method and fix the conflict Signed-off-by: mloufra <[email protected]> * fix merge conflict Signed-off-by: mloufra <[email protected]> * Add code coverage report Signed-off-by: mloufra <[email protected]> * Rebase the lastest commit Signed-off-by: mloufra <[email protected]> * Add code coverage report Signed-off-by: mloufra <[email protected]> * delete --coverage Signed-off-by: mloufra <[email protected]> Signed-off-by: mloufra <[email protected]>
Description
The purpose for this PR is to use JaCoCo to collect these results and push them to codecov.io.
The following step is my idea to hit the mark.
build.yml
to add the code after reviewing each yml file in workflow folder)Issues Resolved
#48
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.