Removed setters to avoid accessing extension attributes

Signed-off-by: Owais Kazi <[email protected]>
opensearch-project · Jul 13, 2022 · 77f7a50 · 77f7a50
1 parent 94f720e
commit 77f7a50
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 34 deletions.
diff --git a/src/main/java/org/opensearch/sdk/ActionListener.java b/src/main/java/org/opensearch/sdk/ActionListener.java
@@ -21,9 +21,6 @@
 import java.net.Socket;
 import java.net.UnknownHostException;
 
-/**
- * The class for Action Listener to run SDK
- */
 public class ActionListener {
 
     @SuppressForbidden(reason = "need local ephemeral port")

diff --git a/src/main/java/org/opensearch/sdk/ClusterSettingsResponseHandler.java b/src/main/java/org/opensearch/sdk/ClusterSettingsResponseHandler.java
@@ -10,9 +10,6 @@
 
 import java.io.IOException;
 
-/**
- * Transport Response Handler class for Cluster Settings API
- */
 public class ClusterSettingsResponseHandler implements TransportResponseHandler<ClusterSettingsResponse> {
     private static final Logger logger = LogManager.getLogger(ClusterSettingsResponseHandler.class);
 

diff --git a/src/main/java/org/opensearch/sdk/ClusterStateResponseHandler.java b/src/main/java/org/opensearch/sdk/ClusterStateResponseHandler.java
@@ -10,9 +10,6 @@
 
 import java.io.IOException;
 
-/**
- * Transport Response Handler class for Cluster State API
- */
 public class ClusterStateResponseHandler implements TransportResponseHandler<ClusterStateResponse> {
     private static final Logger logger = LogManager.getLogger(ClusterStateResponseHandler.class);
 

diff --git a/src/main/java/org/opensearch/sdk/ExtensionSettings.java b/src/main/java/org/opensearch/sdk/ExtensionSettings.java
@@ -11,9 +11,6 @@
 
 package org.opensearch.sdk;
 
-/**
- * The class to read extension properties
- */
 public class ExtensionSettings {
 
     private String extensionname;
@@ -22,30 +19,26 @@ public class ExtensionSettings {
     // Change the location to extension.yml file of the extension
     public static final String EXTENSION_DESCRIPTOR = "src/test/resources/extension.yml";
 
-    public String getExtensionname() {
-        return extensionname;
+    public ExtensionSettings(String extensionname, String hostaddress, String hostport) {
+        this.extensionname = extensionname;
+        this.hostaddress = hostaddress;
+        this.hostport = hostport;
     }
 
-    public void setExtensionname(String extensionname) {
-        this.extensionname = extensionname;
+    public ExtensionSettings() {}
+
+    public String getExtensionname() {
+        return extensionname;
     }
 
     public String getHostaddress() {
         return hostaddress;
     }
 
-    public void setHostaddress(String hostaddress) {
-        this.hostaddress = hostaddress;
-    }
-
     public String getHostport() {
         return hostport;
     }
 
-    public void setHostport(String hostport) {
-        this.hostport = hostport;
-    }
-
     @Override
     public String toString() {
         return "\nnodename: " + extensionname + "\nhostaddress: " + hostaddress + "\nhostPort: " + hostport + "\n";

diff --git a/src/main/java/org/opensearch/sdk/ExtensionsRunner.java b/src/main/java/org/opensearch/sdk/ExtensionsRunner.java
@@ -55,9 +55,6 @@
 import static java.util.Collections.emptySet;
 import static org.opensearch.common.UUIDs.randomBase64UUID;
 
-/**
- * The main class for OpenSearch SDK
- */
 public class ExtensionsRunner {
     private ExtensionSettings extensionSettings = readExtensionSettings();
     private DiscoveryNode opensearchNode;

diff --git a/src/main/java/org/opensearch/sdk/LocalNodeResponseHandler.java b/src/main/java/org/opensearch/sdk/LocalNodeResponseHandler.java
@@ -10,9 +10,6 @@
 
 import java.io.IOException;
 
-/**
- * Transport Response Handler class for Local Node API
- */
 public class LocalNodeResponseHandler implements TransportResponseHandler<LocalNodeResponse> {
     private static final Logger logger = LogManager.getLogger(LocalNodeResponseHandler.class);
 

diff --git a/src/test/java/org/opensearch/sdk/TestExtensionSettings.java b/src/test/java/org/opensearch/sdk/TestExtensionSettings.java
@@ -10,24 +10,21 @@ public class TestExtensionSettings extends OpenSearchTestCase {
 
     @BeforeEach
     public void setUp() {
-        extensionSettings = new ExtensionSettings();
+        extensionSettings = new ExtensionSettings("test-extension", "127.0.0.1", "1234");
     }
 
     @Test
     public void testExtensionName() {
-        extensionSettings.setExtensionname("test-extension");
         assertEquals(extensionSettings.getExtensionname(), "test-extension");
     }
 
     @Test
     public void testHostAddress() {
-        extensionSettings.setHostaddress("127.0.0.1");
         assertEquals(extensionSettings.getHostaddress(), "127.0.0.1");
     }
 
     @Test
     public void testHostPort() {
-        extensionSettings.setHostport("1234");
         assertEquals(extensionSettings.getHostport(), "1234");
     }
 }