Addressed PR Comments

Signed-off-by: Owais Kazi <[email protected]>

src/main/java/org/opensearch/sdk/ActionListener.java

@@ -21,6 +21,9 @@
 import java.net.Socket;
 import java.net.UnknownHostException;
 
+/**
+ * The class for Action Listener to run SDK
+ */
 public class ActionListener {
 
     @SuppressForbidden(reason = "need local ephemeral port")

src/main/java/org/opensearch/sdk/ClusterSettingsResponseHandler.java

@@ -10,6 +10,9 @@
 
 import java.io.IOException;
 
+/**
+ * Transport Response Handler class for Cluster Settings API
+ */
 public class ClusterSettingsResponseHandler implements TransportResponseHandler<ClusterSettingsResponse> {
     private static final Logger logger = LogManager.getLogger(ClusterSettingsResponseHandler.class);
 

src/main/java/org/opensearch/sdk/ClusterStateResponseHandler.java

@@ -10,6 +10,9 @@
 
 import java.io.IOException;
 
+/**
+ * Transport Response Handler class for Cluster State API
+ */
 public class ClusterStateResponseHandler implements TransportResponseHandler<ClusterStateResponse> {
     private static final Logger logger = LogManager.getLogger(ClusterStateResponseHandler.class);
 

src/main/java/org/opensearch/sdk/ExtensionSettings.java

@@ -11,6 +11,9 @@
 
 package org.opensearch.sdk;
 
+/**
+ * The class to read extension properties
+ */
 public class ExtensionSettings {
 
     private String extensionname;

src/main/java/org/opensearch/sdk/ExtensionsRunner.java

@@ -55,6 +55,9 @@
 import static java.util.Collections.emptySet;
 import static org.opensearch.common.UUIDs.randomBase64UUID;
 
+/**
+ * The main class for OpenSearch SDK
+ */
 public class ExtensionsRunner {
     private ExtensionSettings extensionSettings = readExtensionSettings();
     private DiscoveryNode opensearchNode;
@@ -144,7 +147,7 @@ public Netty4Transport getNetty4Transport(Settings settings, ThreadPool threadPo
         return transport;
     }
 
-    public TransportService createTransportService(Settings settings) throws IOException {
+    public TransportService createTransportService(Settings settings){
 
         ThreadPool threadPool = new ThreadPool(settings);
 

src/main/java/org/opensearch/sdk/LocalNodeResponseHandler.java

@@ -10,6 +10,9 @@
 
 import java.io.IOException;
 
+/**
+ * Transport Response Handler class for Local Node API
+ */
 public class LocalNodeResponseHandler implements TransportResponseHandler<LocalNodeResponse> {
     private static final Logger logger = LogManager.getLogger(LocalNodeResponseHandler.class);
 

src/test/java/org/opensearch/sdk/TestExtensionSettings.java

@@ -1,15 +1,15 @@
 package org.opensearch.sdk;
 
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.opensearch.test.OpenSearchTestCase;
 
 public class TestExtensionSettings extends OpenSearchTestCase {
 
-    private ExtensionSettings extensionSettings;
+    private static ExtensionSettings extensionSettings;
 
-    @BeforeEach
-    public void setUp() {
+    @BeforeAll
+    public static void setup() {
         extensionSettings = new ExtensionSettings();
     }
 

src/test/java/org/opensearch/sdk/TestExtensionsRunner.java

@@ -22,6 +22,7 @@
 import static org.mockito.Mockito.mock;
 
 import java.net.InetAddress;
+import java.net.UnknownHostException;
 import java.util.Collections;
 
 import org.junit.jupiter.api.BeforeEach;
@@ -61,13 +62,13 @@ public void setUp() throws Exception {
 
     // test ExtensionsRunner getTransportService return type is transport service
     @Test
-    public void testGetTransportService() throws Exception {
+    public void testGetTransportService() {
         assert (extensionsRunner.createTransportService(settings) instanceof TransportService);
     }
 
     // test manager method invokes start on transport service
     @Test
-    public void testTransportServiceStarted() throws Exception {
+    public void testTransportServiceStarted() {
 
         // verify mocked object interaction in manager method
         extensionsRunner.startTransportService(transportService);
@@ -76,22 +77,22 @@ public void testTransportServiceStarted() throws Exception {
 
     // test manager method invokes accept incoming requests on transport service
     @Test
-    public void testTransportServiceAcceptedIncomingRequests() throws Exception {
+    public void testTransportServiceAcceptedIncomingRequests() {
 
         // verify mocked object interaction in manager method
         extensionsRunner.startTransportService(transportService);
         verify(transportService, times(1)).acceptIncomingRequests();
     }
 
     @Test
-    public void testRegisterRequestHandler() throws Exception {
+    public void testRegisterRequestHandler() {
 
         extensionsRunner.startTransportService(transportService);
         verify(transportService, times(3)).registerRequestHandler(anyString(), anyString(), anyBoolean(), anyBoolean(), any(), any());
     }
 
     @Test
-    public void testHandlePluginsRequest() throws Exception {
+    public void testHandlePluginsRequest() throws UnknownHostException {
         DiscoveryNode sourceNode = new DiscoveryNode(
             "test_node",
             new TransportAddress(InetAddress.getByName("localhost"), 9876),
@@ -108,23 +109,23 @@ public void testHandlePluginsRequest() throws Exception {
     }
 
     @Test
-    public void testClusterStateRequest() throws Exception {
+    public void testClusterStateRequest() {
 
         extensionsRunner.sendClusterStateRequest(transportService);
 
         verify(transportService, times(1)).sendRequest(any(), anyString(), any(), any());
     }
 
     @Test
-    public void testClusterSettingRequest() throws Exception {
+    public void testClusterSettingRequest() {
 
         extensionsRunner.sendClusterSettingRequest(transportService);
 
         verify(transportService, times(1)).sendRequest(any(), anyString(), any(), any());
     }
 
     @Test
-    public void testLocalNodeRequest() throws Exception {
+    public void testLocalNodeRequest() {
 
         extensionsRunner.sendLocalNodeRequest(transportService);