-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect variable name #247
Conversation
Signed-off-by: Matt Larraz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it! Care to write a unit test please?
Any guidance on which file to put it in? |
There's currently no unit tests for this yet. If you're to add one, it should be in require_relative '../../../spec_helper'
describe 'OpenSearch::Client#respond_to_missing?' do
it 'returns to correct results' do
client = OpenSearch::Client.new
expect(client.send(:respond_to_missing?, :perform_request)).to be true
expect(client.send(:respond_to_missing?, :something_else)).to be false
end
end |
Signed-off-by: Theo Truong <[email protected]>
Signed-off-by: Theo Truong <[email protected]>
@mlarraz I've created a PR into your branch: https://github.com/mlarraz/opensearch-ruby/pull/1/files |
Signed-off-by: Theo Truong <[email protected]>
@mlarraz Corrected the header: https://github.com/mlarraz/opensearch-ruby/pull/2/files |
@dblock Would you mind adding your review? I have commits in this PR so my review doesn't count. |
Should we change the number of approvers like in opensearch-project/opensearch-php#179? If you agree open an issue and I'll vote yes @nhtruong? :) |
@dblock I thought this one only needed 1 approver. Let's do that like other small repos we have. |
@nhtruong You're right, not sure what I was seeing, maybe an unresolved conversation or smth... ignore me. |
I saw |
Description
This appears to be a typo that causes error when
#respond_to?
is called on either of these objects.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.