Fix release workflow #234
Merged
Fix release workflow #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See opensearch-project#232 I have manually confirmed that gem install with ruby 3.0 works Signed-off-by: Earlopain <[email protected]>
Earlopain
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
dblock,
VachaShah,
nhtruong and
harshavamsi
as code owners
dblock
approved these changes
Apr 10, 2024
|
I doesn't look like this was sufficient, https://build.ci.opensearch.org/blue/organizations/jenkins/opensearch-ruby-gems-release/detail/opensearch-ruby-gems-release/32/pipeline shows exactly the same error. Sorry about that, really thought this was it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per https://github.com/opensearch-project/opensearch-build-libraries/blob/6d35e942e98e1acddd88633a2aa1bbe39ab5e002/vars/publishToRubyGems.groovy#L23 this is a supported config option.
The build failure is visible here: https://build.ci.opensearch.org/blue/organizations/jenkins/opensearch-ruby-gems-release/detail/opensearch-ruby-gems-release/31/pipeline
Issues Resolved
#232. I have manually confirmed that gem install with ruby 3.0 works. There are other warnings in the output relating to gem signing but I'm thinking that these are just errors happening down the road because of the the ruby version incompatibility.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.