Missing require #206
Merged
Missing require #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundle exec loads gem/version through the gemspec file CI doesn't need bundle exec since each gem will only be available once anyways Signed-off-by: Earlopain <[email protected]>
Fixes #205 Signed-off-by: Earlopain <[email protected]>
Earlopain
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
dblock,
VachaShah,
nhtruong and
harshavamsi
as code owners
beetlegius-jt
approved these changes
Sep 18, 2023
dblock
approved these changes
Sep 18, 2023
nhtruong
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a missing require to
opensearch/version.CI didn't catch this because
bundle exec rakeloads the gemspec file which requires the version on it's own. CI has no need forbundle execsince there will only ever be the exact gems installed so I have changed workflow to call rake on it's own.Issues Resolved
#205
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.