Modified index definition in client/__init__py #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
saimedhi
force-pushed
the
fix/client/__init__.py/index
branch
from
bfe9d7d to
86290db
Compare
dblock
requested changes
Nov 28, 2022
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ### Changed | |||
| - Updated getting started to user guide ([#233](https://github.com/opensearch-project/opensearch-py/pull/233)) | |||
| - Updated CA certificate handling to check OpenSSL environment variables before defaulting to certifi ([#196](https://github.com/opensearch-project/opensearch-py/pull/196)) | |||
| - Modified index definition in client/__init__py([#245](https://github.com/opensearch-project/opensearch-py/pull/245)) | |||
There was a problem hiding this comment.
No need for a CHANGELOG entry for a doc change, you can remove. It needs an extra space before ( otherwise I would have merged anyway :)
Signed-off-by: saimedhi <[email protected]>
saimedhi
force-pushed
the
fix/client/__init__.py/index
branch
from
86290db to
b3c5018
Compare
dblock
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: saimedhi [email protected]
Description
Modified index definition in client/__init__py
Issues Resolved
Closes #132
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.