-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to test against various versions of OpenSearch #146
Add support to test against various versions of OpenSearch #146
Conversation
…enSearch Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
strategy: | ||
fail-fast: false | ||
matrix: | ||
cluster: ["opendistro"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need this as a parameter. You can directly use opendistro at line 19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad 🤦🏼♀️
b838ca4
to
6a73620
Compare
@@ -0,0 +1,18 @@ | |||
name: Integration tests with OpenDistro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file extension is missing. ".yml" . I believe thats why this job is not picked up by github workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops!! I fixed it
Signed-off-by: Vacha Shah <[email protected]>
6a73620
to
faf550e
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-146-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 172a3179abeaa0469c7e18b89cff4a610e7dbd6a
# Push it to GitHub
git push --set-upstream origin backport/backport-146-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
* Adding support to run integration tests across various versions of OpenSearch Signed-off-by: Vacha Shah <[email protected]> * Adding a compatibility matrix and getting started guide with formatting Signed-off-by: Vacha Shah <[email protected]> * Splitting jobs for opendistro and opensearch Signed-off-by: Vacha Shah <[email protected]>
* Adding support to run integration tests across various versions of OpenSearch Signed-off-by: Vacha Shah <[email protected]> * Adding a compatibility matrix and getting started guide with formatting Signed-off-by: Vacha Shah <[email protected]> * Splitting jobs for opendistro and opensearch Signed-off-by: Vacha Shah <[email protected]>
Description
Add support to run integration tests against various versions of OpenSearch for compatibility and publish a compatibility matrix. Also includes changes to markdown files.
Issues Resolved
#144
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.