Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to test against various versions of OpenSearch #146

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

VachaShah
Copy link
Collaborator

Description

Add support to run integration tests against various versions of OpenSearch for compatibility and publish a compatibility matrix. Also includes changes to markdown files.

Issues Resolved

#144

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VachaShah VachaShah requested review from VijayanB and Shivamdhar April 5, 2022 06:30
.ci/run-tests Show resolved Hide resolved
strategy:
fail-fast: false
matrix:
cluster: ["opendistro"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this as a parameter. You can directly use opendistro at line 19

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad 🤦🏼‍♀️

@VachaShah VachaShah force-pushed the test-multiple-versions branch from b838ca4 to 6a73620 Compare April 5, 2022 19:11
@VachaShah VachaShah requested a review from VijayanB April 5, 2022 19:18
@@ -0,0 +1,18 @@
name: Integration tests with OpenDistro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file extension is missing. ".yml" . I believe thats why this job is not picked up by github workflow.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!! I fixed it

@VachaShah VachaShah force-pushed the test-multiple-versions branch from 6a73620 to faf550e Compare April 5, 2022 19:27
@VachaShah VachaShah merged commit 172a317 into opensearch-project:main Apr 5, 2022
@VachaShah VachaShah deleted the test-multiple-versions branch April 5, 2022 21:57
@VachaShah VachaShah added the backport 1.x Backport to 1.x branch label Apr 19, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-146-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 172a3179abeaa0469c7e18b89cff4a610e7dbd6a
# Push it to GitHub
git push --set-upstream origin backport/backport-146-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-146-to-1.x.

VachaShah added a commit that referenced this pull request Apr 19, 2022
* Adding support to run integration tests across various versions of OpenSearch

Signed-off-by: Vacha Shah <[email protected]>

* Adding a compatibility matrix and getting started guide with formatting

Signed-off-by: Vacha Shah <[email protected]>

* Splitting jobs for opendistro and opensearch

Signed-off-by: Vacha Shah <[email protected]>
VachaShah added a commit that referenced this pull request Apr 20, 2022
* Adding support to run integration tests across various versions of OpenSearch

Signed-off-by: Vacha Shah <[email protected]>

* Adding a compatibility matrix and getting started guide with formatting

Signed-off-by: Vacha Shah <[email protected]>

* Splitting jobs for opendistro and opensearch

Signed-off-by: Vacha Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x Backport to 1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants