-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSCI] Add ML-Commons Train and Predict api functionality in py-ml #312
base: main
Are you sure you want to change the base?
[OSCI] Add ML-Commons Train and Predict api functionality in py-ml #312
Conversation
Signed-off-by: VincentZhao12 <[email protected]>
Signed-off-by: VincentZhao12 <[email protected]>
Signed-off-by: VincentZhao12 <[email protected]>
Signed-off-by: VincentZhao12 <[email protected]>
Signed-off-by: VincentZhao12 <[email protected]>
Signed-off-by: VincentZhao12 <[email protected]>
Not quite sure why for your integration tests aren't running. Did you test in your end? |
When I ran the tests locally, it passed all tests. |
Could you please resolve the merge conflict? |
@VincentZhao12 are you working on this? |
Sorry, I just saw this. Yes I am working on it, I will resolve merge conflicts and commit |
Signed-off-by: Vincent Zhao <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 91.47% 90.26% -1.22%
==========================================
Files 41 41
Lines 4365 4427 +62
==========================================
+ Hits 3993 3996 +3
- Misses 372 431 +59 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Vincent Zhao <[email protected]>
add unit test. |
Signed-off-by: Vincent Zhao <[email protected]>
Description
Added train and predict method and test cases for it in ml-commons-client.py that uses the ML Commons API to train a model and make a prediction using the given dataset.
Issues Resolved
Closes #288
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.