Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSCI] Add ML-Commons Train and Predict api functionality in py-ml #312

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

VincentZhao12
Copy link
Contributor

@VincentZhao12 VincentZhao12 commented Oct 11, 2023

Description

Added train and predict method and test cases for it in ml-commons-client.py that uses the ML Commons API to train a model and make a prediction using the given dataset.

Issues Resolved

Closes #288

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

VincentZhao12 added 4 commits October 11, 2023 02:53
Signed-off-by: VincentZhao12 <[email protected]>
Signed-off-by: VincentZhao12 <[email protected]>
Signed-off-by: VincentZhao12 <[email protected]>
VincentZhao12 added 2 commits October 12, 2023 18:54
Signed-off-by: VincentZhao12 <[email protected]>
Signed-off-by: VincentZhao12 <[email protected]>
@dhrubo-os
Copy link
Collaborator

Not quite sure why for your integration tests aren't running. Did you test in your end?

@VincentZhao12
Copy link
Contributor Author

When I ran the tests locally, it passed all tests.

@dhrubo-os
Copy link
Collaborator

Could you please resolve the merge conflict?

@dhrubo-os
Copy link
Collaborator

@VincentZhao12 are you working on this?

@VincentZhao12
Copy link
Contributor Author

Sorry, I just saw this. Yes I am working on it, I will resolve merge conflicts and commit

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (1666baa) 91.47% compared to head (68e2284) 90.26%.

Files Patch % Lines
opensearch_py_ml/ml_commons/ml_commons_client.py 3.22% 60 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   91.47%   90.26%   -1.22%     
==========================================
  Files          41       41              
  Lines        4365     4427      +62     
==========================================
+ Hits         3993     3996       +3     
- Misses        372      431      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vincent Zhao <[email protected]>
@dhrubo-os
Copy link
Collaborator

add unit test.

Signed-off-by: Vincent Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]Add ML-Commons Train and predict api functionality in py-ml
2 participants