Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Ensure plugins work with Dashboards Node v14.18.2 #118

Closed
8 tasks done
boktorbb opened this issue Dec 17, 2021 · 5 comments
Closed
8 tasks done

[Meta] Ensure plugins work with Dashboards Node v14.18.2 #118

boktorbb opened this issue Dec 17, 2021 · 5 comments
Labels
enhancement New feature or request v2.0.0

Comments

@boktorbb
Copy link

boktorbb commented Dec 17, 2021

Dashboards has upgraded Node to v14.18.2 and this is for plugin teams to verify that their plugins work with the new version upgrade. The Dashboards branch running the upgraded node is main.

Here is the parent Node 14 upgrade issue: opensearch-project/OpenSearch-Dashboards#920

A list of things to check is:

  • Your plugin's node version is bumped to 14.18.2
  • Your plugin's @types/node package is bumped to ^14.17.32 if it's used
  • Plugin builds and runs on Dashboards
  • All of your plugin's tests pass
  • Your GitHub workflows are not broken by the node version change and updated if they do
  • Any sanity/smoke testing is successful
@dblock
Copy link
Member

dblock commented Dec 18, 2021

Did you mean this to be a parent issue and open one in each plugin?

@boktorbb
Copy link
Author

boktorbb commented Dec 18, 2021

Did you mean this to be a parent issue and open one in each plugin?

I meant for each plugin team to verify their plugin against our Node 14 branch in case I missed anything in my own investigation. I’m not sure if I was supposed to open just a parent issue here or one in each Dashboards plugin repo.

@dblock
Copy link
Member

dblock commented Dec 18, 2021

Did you mean this to be a parent issue and open one in each plugin?

I meant for each plugin team to verify their plugin against our Node 14 branch in case I missed anything in my own investigation. I’m not sure if I was supposed to open just a parent issue here or one in each Dashboards plugin repo.

Make this a parent issue and open an issue in every plugin using meta. It should look like this for example.

@boktorbb boktorbb changed the title Ensure plugins work with Dashboards Node v14.18.2 [Meta] Ensure plugins work with Dashboards Node v14.18.2 Dec 20, 2021
@dblock
Copy link
Member

dblock commented Apr 18, 2022

@boktorbb-amzn What shall we do about this?

@dblock dblock added the v2.0.0 label Apr 18, 2022
@boktorbb
Copy link
Author

boktorbb commented Apr 18, 2022

@boktorbb-amzn What shall we do about this?

@dblock As long as all plugins are building against Dashboards 2.0 successfully then we can close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.0.0
Projects
None yet
Development

No branches or pull requests

2 participants