Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plugin works with Dashboards Node upgrade v14.18.2 #115

Closed
boktorbb opened this issue Dec 17, 2021 · 1 comment
Closed

Ensure plugin works with Dashboards Node upgrade v14.18.2 #115

boktorbb opened this issue Dec 17, 2021 · 1 comment

Comments

@boktorbb
Copy link

Dashboards has upgraded Node to v14.18.2 and this is for plugin teams to verify that their plugins work with the new version upgrade. The Dashboards branch running the upgraded node is feature/node14.

A list of things to check is:

  • Your plugin's node version is bumped to 14.18.2
  • Your plugin's @types/node package is bumped to ^14.17.32 if it's used
  • Plugin builds and runs on Dashboards
  • All of your plugin's tests pass
  • Your GitHub workflows are not broken by the node version change and updated if they do
  • Any sanity/smoke testing is successful
@dblock
Copy link
Member

dblock commented Dec 18, 2021

Looks like some test automation issues ... Closing all but #118.

@dblock dblock closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants