Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added samples, updated links. #218

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Added samples, updated links. #218

merged 2 commits into from
Aug 9, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 5, 2024

Description

  • Added a samples folder with a runnable hello world index.php.
  • Made links relative.
  • Fixed up some version comparisons in tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <[email protected]>
@dblock dblock marked this pull request as ready for review August 5, 2024 18:50
shyim
shyim previously approved these changes Aug 5, 2024
@dblock dblock marked this pull request as draft August 5, 2024 20:21
@dblock
Copy link
Member Author

dblock commented Aug 5, 2024

The 3.0, 1.x and 2.x tests are failing because these are using the -min distribution that doesn't have the ML plugin. I split the suites into Integration and Integration-Min. The 2.0 branch doesn't need to be tested, 2.0.1 was the last 2.0 release. Added 2.14 and 2.15 that have GAed.

@dblock dblock marked this pull request as ready for review August 5, 2024 20:38
@dblock
Copy link
Member Author

dblock commented Aug 9, 2024

@shyim let's get this merged?

@shyim shyim merged commit 73c4b11 into opensearch-project:main Aug 9, 2024
47 of 48 checks passed
@shyim
Copy link
Collaborator

shyim commented Aug 9, 2024

Thanks! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants