Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added highlight to search endpoint whitelist #171

Closed
wants to merge 1 commit into from
Closed

added highlight to search endpoint whitelist #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/OpenSearch/Endpoints/Search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@
'batched_reduce_size',
'max_concurrent_shard_requests',
'pre_filter_shard_size',
'rest_total_hits_as_int'
'rest_total_hits_as_int',
'highlight'

Check warning on line 82 in src/OpenSearch/Endpoints/Search.php

View check run for this annotation

Codecov / codecov/patch

src/OpenSearch/Endpoints/Search.php#L81-L82 

Added lines #L81 - L82 were not covered by tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prattcmp, it looks like highlight isn't a valid parameter for the Search API. I tested it. Search doesn't include the highlight parameter here.

If you think there's something missing, feel free to contribute! You can also consider contributing to the opensearch API specification here and adding any missing parameters. Thanks!

];
}

Expand Down
Loading