Fix warning in Connection::tryDeserializeError() #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Seidl <[email protected]>
drunken-monkey
requested review from
VachaShah,
dblock,
harshavamsi and
shyim
as code owners
shyim
previously approved these changes
Nov 18, 2023
|
@drunken-monkey Your second commit is missing DCO, please? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
============================================
- Coverage 24.19% 24.19% -0.01%
+ Complexity 1938 1936 -2
============================================
Files 246 246
Lines 6865 6862 -3
============================================
- Hits 1661 1660 -1
+ Misses 5204 5202 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Seidl <[email protected]>
drunken-monkey
force-pushed
the
167--fix-tryDeserializeError-warning
branch
from
ecf7f6f to
7b432c2
Compare
Sorry, fixed! |
|
Do add a line to CHANGELOG. This fixes a bug. |
dblock
approved these changes
Nov 22, 2023
|
@drunken-monkey You have to amend your last commit to pass DCO, please? |
Signed-off-by: Thomas Seidl <[email protected]>
drunken-monkey
force-pushed
the
167--fix-tryDeserializeError-warning
branch
from
cc67d75 to
dbd796f
Compare
|
Can this get brought in? It is causing headaches with AWS OSS |
dblock
approved these changes
Mar 27, 2024
|
Need another maintainer to approve. @VachaShah @shyim @harshavamsi ? |
shyim
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes code in
\OpenSearch\Connections\Connection::tryDeserializeError()to properly check whether$error['error']['root_cause']exists before accessing it.Issues Resolved
Closes #167.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.