Added changelog and deprecation trigger

Signed-off-by: Kim Pepper <[email protected]>
opensearch-project · Nov 13, 2024 · c4540df · c4540df
1 parent 46357f4
commit c4540df
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Increased min version of `ezimuel/ringphp` to `^1.2.2`
 - Changed fluent setters to return static
 ### Deprecated
+- Passing a callable to for retrieving endpoints is deprecated and replaced with passing an EndpointFactory ([#237](https://github.com/opensearch-project/opensearch-php/pull/237))
 ### Removed
 ### Fixed
 - Fixed PHP 8.4 deprecations

diff --git a/src/OpenSearch/ClientBuilder.php b/src/OpenSearch/ClientBuilder.php
@@ -186,6 +186,7 @@ public function getTransport(): Transport
      */
     public function getEndpoint(): callable
     {
+        @trigger_error(__METHOD__ . '() is deprecated in 2.3.2 and will be removed in 3.0.0. Use \OpenSearch\ClientBuilder::getEndpointFactory() instead.', E_USER_DEPRECATED);
         return fn ($c) => $this->endpointFactory->getEndpoint('OpenSearch\\Endpoints\\' . $c);
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -186,6 +186,7 @@ public function getTransport(): Transport @@
          */
         public function getEndpoint(): callable
         {
+            @trigger_error(__METHOD__ . '() is deprecated in 2.3.2 and will be removed in 3.0.0. Use \OpenSearch\ClientBuilder::getEndpointFactory() instead.', E_USER_DEPRECATED);
             return fn ($c) => $this->endpointFactory->getEndpoint('OpenSearch\\Endpoints\\' . $c);
         }
@@ Expand Down @@