Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run more of the tests that have been ignored or missed #98

Merged
merged 12 commits into from
Oct 14, 2022

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Sep 14, 2022

Description

This PR ensures more of the tests that have been ignored or missed are actually run:

  • Tests.Reproduce was not running due to a missing dependency on xunit.runner.visualstudio
  • There was a reproduce test lost under a Reproduce folder outside the test project
  • Integration tests were only being run in the Tests project, not those in Tests.Reproduce
  • Fix broken reproduce tests that hadn't been being run
  • Run the tests related to "abstractions"
  • Remove references to OpenDistro/ODFE as it has been completely archived and the downloads no longer function

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia requested review from a team and Yury-Fridlyand as code owners September 14, 2022 02:23
@MaxKsyunz
Copy link
Collaborator

@Xtansia do you know why Tests.Reproduce.GitHubIssue4537.CanDeserializeSnapshotShardFailure test failed in the Create Release Candidate workflow?

@Yury-Fridlyand
Copy link
Collaborator

There is a flaky test in Reproduce. I rerun the workflow and now it pass.

@Yury-Fridlyand
Copy link
Collaborator

Actually, there are more than 100 not executed integration tests and few dozens of deactivated UT and IT.
Just a fact, it is not a proposal to fix them in scope of one PR.

@Xtansia
Copy link
Collaborator Author

Xtansia commented Sep 15, 2022

Actually, there are more than 100 not executed integration tests and few dozens of deactivated UT and IT. Just a fact, it is not a proposal to fix them in scope of one PR.

Is this just related to tests with [Skip] attributes, or some larger group?

@Yury-Fridlyand
Copy link
Collaborator

Unfortunately, there is larger group.
Tests with [Skip] are deactivated due to some bugs or limitations of specific product version.

@Xtansia Xtansia changed the title Ensure all tests are being run Run more of the tests that have been ignored or missed Oct 10, 2022
dblock
dblock previously approved these changes Oct 11, 2022
Signed-off-by: Thomas Farr <[email protected]>
@VachaShah VachaShah merged commit abd6402 into opensearch-project:main Oct 14, 2022
@Xtansia Xtansia deleted the fix/tests branch January 16, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants