Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the version. #93

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury-Fridlyand [email protected]

Description

Bump release version to 1.1.0.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <[email protected]>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be doing this every time after a release, preparing for the next developer iteration.

@Yury-Fridlyand
Copy link
Collaborator Author

This goes to the main, not to 1.1.0 branch.

@harshavamsi
Copy link
Contributor

harshavamsi commented Sep 6, 2022

We should be doing this every time after a release, preparing for the next developer iteration.

@dblock correct me if I'm wrong here, but shouldn't this be done before a release. The release artifacts still point to the older 1.0.0 version unless we update them here first.

I understand what you mean now, lost in interpretation...

@Yury-Fridlyand Yury-Fridlyand merged commit 7c8a709 into opensearch-project:main Sep 6, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the rel-bump-ver-1.1.0 branch September 6, 2022 19:33
@Yury-Fridlyand Yury-Fridlyand restored the rel-bump-ver-1.1.0 branch September 6, 2022 19:52
@dblock
Copy link
Member

dblock commented Sep 6, 2022

@harshavamsi My favorite reason why version should be incremented to the next development iteration right after a release is because I don't ever want to rebuild code with changes that happened after the said release. So let's say we release 1.0.0, the next patch version is always 1.0.1 per semver (incremented immediately) and there's never again a 1.0.0 build. If someone PRs a new feature, they increment the version to 1.1.0 in their PR, again per semver, otherwise we're always ready to release a (security) patch 1.0.1.

@Yury-Fridlyand Yury-Fridlyand deleted the rel-bump-ver-1.1.0 branch September 9, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants