-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deserialization of S3 snapshot repository without settings #587
Merged
dblock
merged 2 commits into
opensearch-project:main
from
Xtansia:fix/573-s3-snapshot-repository-deserialization
Apr 10, 2024
Merged
Fix deserialization of S3 snapshot repository without settings #587
dblock
merged 2 commits into
opensearch-project:main
from
Xtansia:fix/573-s3-snapshot-repository-deserialization
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
force-pushed
the
fix/573-s3-snapshot-repository-deserialization
branch
from
April 9, 2024 01:29
e6e4882
to
a266d86
Compare
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
requested review from
anirudha,
dblock,
joshuali925,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
April 9, 2024 02:34
dblock
approved these changes
Apr 10, 2024
Xtansia
added
backport 1.x
Backport to 1.x branch
backport 1.7
Backport to the 1.7 branch
labels
Apr 10, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-587-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df942ab3d545cad71b1dc1c9222d6d4410c092c2
# Push it to GitHub
git push --set-upstream origin backport/backport-587-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7 1.7
# Navigate to the new working tree
cd .worktrees/backport-1.7
# Create a new branch
git switch --create backport/backport-587-to-1.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df942ab3d545cad71b1dc1c9222d6d4410c092c2
# Push it to GitHub
git push --set-upstream origin backport/backport-587-to-1.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7 Then, create a pull request where the |
Xtansia
added a commit
to Xtansia/opensearch-net
that referenced
this pull request
Apr 10, 2024
…earch-project#587) * Add failing reproduction test case Signed-off-by: Thomas Farr <[email protected]> * Add parameterless constructor to S3Repository Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit df942ab)
dblock
pushed a commit
that referenced
this pull request
Apr 11, 2024
…#596) * Add failing reproduction test case Signed-off-by: Thomas Farr <[email protected]> * Add parameterless constructor to S3Repository Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit df942ab)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
…#596) * Add failing reproduction test case Signed-off-by: Thomas Farr <[email protected]> * Add parameterless constructor to S3Repository Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit df942ab) (cherry picked from commit 241ad92)
Xtansia
added a commit
that referenced
this pull request
Apr 11, 2024
…#596) (#597) * Add failing reproduction test case Signed-off-by: Thomas Farr <[email protected]> * Add parameterless constructor to S3Repository Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit df942ab) (cherry picked from commit 241ad92) Co-authored-by: Thomas Farr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes deserialization of S3 snapshot repository without settings
Issues Resolved
Fixes #573
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.