Allow passing "auto" as the slices parameter
#553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtansia
requested review from
anirudha,
dblock,
joshuali925,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
dblock
previously approved these changes
Feb 27, 2024
|
Conflicts + license headers. |
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Xtansia
force-pushed
the
fix/allow-setting-slices-auto
branch
from
2f850ad to
18ae9b5
Compare
|
@dblock Have fixed those |
dblock
approved these changes
Feb 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* Allow passing `"auto"` as the `slices` parameter Signed-off-by: Thomas Farr <[email protected]> * Update CHANGELOG Signed-off-by: Thomas Farr <[email protected]> * Fix license header Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit cd4bd52)
Xtansia
added a commit
that referenced
this pull request
Feb 28, 2024
* Allow passing `"auto"` as the `slices` parameter Signed-off-by: Thomas Farr <[email protected]> * Update CHANGELOG Signed-off-by: Thomas Farr <[email protected]> * Fix license header Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit cd4bd52) Co-authored-by: Thomas Farr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows passing the string
"auto"as theslicesparameter.Issues Resolved
Fixes #550
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.