-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually use ConnectionConfiguration.DefaultMemoryStreamFactory #552
Actually use ConnectionConfiguration.DefaultMemoryStreamFactory #552
Conversation
Signed-off-by: Donovan Jimenez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @djimenez!
Only other thing that you'll need to do is add an item into the CHANGELOG.md under a ### Changed
heading inside the ## [Unreleased]
section.
Signed-off-by: Donovan Jimenez <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-552-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 80854014b7376f6882ebb3010c0309a0f9774808
# Push it to GitHub
git push --set-upstream origin backport/backport-552-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
…search-project#552) * actually use ConnectionConfiguration.DefaultMemoryStreamFactory Signed-off-by: Donovan Jimenez <[email protected]> * Add ConnectionConfiguration.DefaultMemoryStreamFactory changelog Signed-off-by: Donovan Jimenez <[email protected]> --------- Signed-off-by: Donovan Jimenez <[email protected]> (cherry picked from commit 8085401)
#560) * actually use ConnectionConfiguration.DefaultMemoryStreamFactory Signed-off-by: Donovan Jimenez <[email protected]> * Add ConnectionConfiguration.DefaultMemoryStreamFactory changelog Signed-off-by: Donovan Jimenez <[email protected]> --------- Signed-off-by: Donovan Jimenez <[email protected]> (cherry picked from commit 8085401) Co-authored-by: Donovan Jimenez <[email protected]>
Description
Use DefaultMemoryStreamFactory static property for the default in ConnectionConfiguration - currently the private member is initialized to a different value, which is confusing.
Issues Resolved
Resolves #551
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.