Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use ConnectionConfiguration.DefaultMemoryStreamFactory #552

Merged

Conversation

djimenez
Copy link
Contributor

Description

Use DefaultMemoryStreamFactory static property for the default in ConnectionConfiguration - currently the private member is initialized to a different value, which is confusing.

Issues Resolved

Resolves #551

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@Xtansia Xtansia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djimenez!

Only other thing that you'll need to do is add an item into the CHANGELOG.md under a ### Changed heading inside the ## [Unreleased] section.

@Xtansia Xtansia merged commit 8085401 into opensearch-project:main Feb 26, 2024
34 of 36 checks passed
@Xtansia Xtansia added the backport 1.x Backport to 1.x branch label Feb 26, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-552-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 80854014b7376f6882ebb3010c0309a0f9774808
# Push it to GitHub
git push --set-upstream origin backport/backport-552-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-552-to-1.x.

Xtansia pushed a commit to Xtansia/opensearch-net that referenced this pull request Feb 26, 2024
…search-project#552)

* actually use ConnectionConfiguration.DefaultMemoryStreamFactory

Signed-off-by: Donovan Jimenez <[email protected]>

* Add ConnectionConfiguration.DefaultMemoryStreamFactory changelog

Signed-off-by: Donovan Jimenez <[email protected]>

---------

Signed-off-by: Donovan Jimenez <[email protected]>
(cherry picked from commit 8085401)
Xtansia added a commit that referenced this pull request Feb 26, 2024
#560)

* actually use ConnectionConfiguration.DefaultMemoryStreamFactory

Signed-off-by: Donovan Jimenez <[email protected]>

* Add ConnectionConfiguration.DefaultMemoryStreamFactory changelog

Signed-off-by: Donovan Jimenez <[email protected]>

---------

Signed-off-by: Donovan Jimenez <[email protected]>
(cherry picked from commit 8085401)

Co-authored-by: Donovan Jimenez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x Backport to 1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ConnectionConfiguration.DefaultMemoryStreamFactory not actually default (potential confusion)
2 participants