GH-281 TermQuery with a string.Empty value needs .Verbatim() or it is ignored as "conditionless" #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidalpert
requested review from
anirudha,
dblock,
joshuali925,
Xtansia,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
Xtansia
requested changes
Jul 16, 2023
There was a problem hiding this comment.
The fix looks good, only thing missing is we'll need an entry added into the CHANGELOG.md under a ### Fixed header in the ## Unreleased section.
I think there might also be value in adding a reproduce test similar to the one you shared here: #281 (comment)
|
@davidalpert It does appear unfortunately this fix breaks some test cases that expect empty string to be conditionless. I'm aware of your issue #282, there's unfortunately some flaky tests in general that make running the tests locally frustrating. The reproduce command from below ( |
|
Thank you for your response; running this command on main: did give me a baseline green from which to test my change and based on that I will try adding some unit tests for my change in the style of this project, and also look to include updates for any tests which break as a result of this PR 👍 |
This was referenced Jul 17, 2023
davidalpert
force-pushed
the
GH-281-fluent-must-not-should-include-must_not-clause-in-search-request-body
branch
from
2caf7a2 to
75707a1
Compare
davidalpert
changed the title
|
@Xtansia I appreciate your prompt engagement with my issue and pull request. I have now learned that a I have updated this PR to revert my proposed change and simply add some unit tests documenting my investigation and discovery from GH-281. Feel free to merge or close without merging these additional test cases. |
davidalpert
force-pushed
the
GH-281-fluent-must-not-should-include-must_not-clause-in-search-request-body
branch
from
75707a1 to
859b22f
Compare
Xtansia
requested changes
Jul 18, 2023
…y string serializes as <null> Signed-off-by: David Alpert <[email protected]>
Further investigation shows that a TermQuery with an empty
string value is expected to be 'conditionless' in this
codebase and the TermQuery implementation includes a
.Verbatim() method to allow the client to serialize
the query clause even though it evaluates to
conditionless
this allows me to create a query like this
GET /index/_search
{
"query": {
"bool": {
"must": [
{"exists": { "field": "last_name"}}
],
"must_not": [
{"term": {"last_name.keyword": {"value": ""}}}
]
}
}
}
using the following syntax
client.Search<SampleDomainObject>(s => s
.Query(q => q
.Bool(b => b
.Must(m => m.Exists(e => e.Field("last_name")))
.MustNot(m => m.Term(t => t.Verbatim().Field("last_name.keyword").Value(string.Empty)))
)
)
.Index("index")
.Source(sfd => null)
);
thus resolving that opensearch-projectGH-281 is not a bug and is working as designed.
Signed-off-by: David Alpert <[email protected]>
opensearch-projectGH-281 Signed-off-by: David Alpert <[email protected]>
davidalpert
force-pushed
the
GH-281-fluent-must-not-should-include-must_not-clause-in-search-request-body
branch
from
42db7ec to
64d94a2
Compare
|
I have updated the PR description and added some examples to USAGE.md |
Xtansia
requested changes
Jul 20, 2023
opensearch-projectGH-281 Signed-off-by: David Alpert <[email protected]>
davidalpert
force-pushed
the
GH-281-fluent-must-not-should-include-must_not-clause-in-search-request-body
branch
from
64d94a2 to
c9a9e4e
Compare
Xtansia
approved these changes
Aug 11, 2023
Yury-Fridlyand
approved these changes
Aug 11, 2023
|
@Yury-Fridlyand so far as I know the I am currently using this |
|
I see. Thank you for the details! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
USAGE.mdto demonstrate use ofIsVerbatim/Verbatim()to includeTermQuerys with non-null empty string valuesIssues Resolved
Resolves GH-281
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: David Alpert [email protected]