Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement code generation from OpenAPI spec #216

Closed
wants to merge 14 commits into from

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented May 17, 2023

Description

Brings back the old ApiGenerator and refactors it to instead base off an OpenAPI spec

Issues Resolved

Closes #193

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand
Copy link
Collaborator

What was changed in API generator? Can I skip first commit for reviewing?

@Xtansia
Copy link
Collaborator Author

Xtansia commented May 18, 2023

What was changed in API generator? Can I skip first commit for reviewing?

First commit is just a direct restore, so can be skipped. Main changes in ApiGenerator were general cleanup and refactoring plus the changes to the api spec parsing. There'll need to be a little more change to make it download the spec from the correct place

@Xtansia
Copy link
Collaborator Author

Xtansia commented May 22, 2023

Can see an example of re-generating the tasks namespace here: Xtansia/opensearch-net@feat/code-generation...Xtansia:opensearch-net:generation/tasks

@Xtansia Xtansia force-pushed the feat/code-generation branch from c192cdc to 0c9a044 Compare May 24, 2023 00:02
@Xtansia Xtansia marked this pull request as ready for review May 24, 2023 03:01
@Xtansia Xtansia marked this pull request as draft June 1, 2023 11:02
@Xtansia
Copy link
Collaborator Author

Xtansia commented Jun 1, 2023

I've decided to break this into smaller PRs with fewer changes to make it easier to review. Starting with just the revert commit in #222

@Xtansia Xtansia force-pushed the feat/code-generation branch from 0c9a044 to 549fe43 Compare June 6, 2023 00:33
@Xtansia Xtansia closed this Jun 7, 2023
@Xtansia Xtansia deleted the feat/code-generation branch October 12, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Generate API code from OpenSearch API Spec
2 participants