Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement k-NN approximate search and mappings bindings #215

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented May 15, 2023

Description

Implements bindings for k-NN approximate search as well as index property mappings.

Issues Resolved

Fixes #178

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia marked this pull request as draft May 15, 2023 04:28
Xtansia added 2 commits May 16, 2023 16:50
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia marked this pull request as ready for review May 16, 2023 04:55
@Xtansia Xtansia added the backport 1.x Backport to 1.x branch label May 22, 2023
@Xtansia Xtansia merged commit 3833005 into opensearch-project:main Jun 26, 2023
@Xtansia Xtansia deleted the feat/knn-bindings branch June 26, 2023 03:24
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-215-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 38330056f3a9e056a98f71e7f3e78dc81d5dc614
# Push it to GitHub
git push --set-upstream origin backport/backport-215-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-215-to-1.x.

Xtansia added a commit to Xtansia/opensearch-net that referenced this pull request Jun 26, 2023
…roject#215)

* Implement KNN bindings

Signed-off-by: Thomas Farr <[email protected]>

* Minimal docs

Signed-off-by: Thomas Farr <[email protected]>

* Add to changelog

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 3833005)
dblock pushed a commit that referenced this pull request Jun 26, 2023
* Implement KNN bindings

Signed-off-by: Thomas Farr <[email protected]>

* Minimal docs

Signed-off-by: Thomas Farr <[email protected]>

* Add to changelog

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 3833005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x Backport to 1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for knn queries
2 participants