Fix data race which can occur when using script and derived expression features with concurrent segment search #54
+54
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n features with concurrent segment search Signed-off-by: Jason Hinch <[email protected]>
jhinch-at-atlassian-com
requested review from
gsingers,
macohen and
sstults
as code owners
JohannesDaniel
approved these changes
Oct 29, 2024
sstults
pushed a commit
to sstults/opensearch-learning-to-rank-base
that referenced
this pull request
Oct 31, 2024
…n features with concurrent segment search (opensearch-project#54) Signed-off-by: Jason Hinch <[email protected]> Signed-off-by: Scott Stults <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A candidate fix as discussed in #52. It is implemented using thread locals to share state between nested data structures in order to share common statistics such as the terms stats and feature vector
Issues Resolved
Fixes: #52
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.