Adding pluginsList and keystore fields to BootstrapConfig #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gergely Szabo <[email protected]>
szamuboy
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
Signed-off-by: Gergely Szabo <[email protected]>
|
Hey @szamuboy thanks for the contribution, the change looks good, can you please fix the failing CI checks and we can merge this. |
|
Thanks @szamuboy, this looks good to me, @swoehrl-mw can you please provide your thoughts on the PR? |
|
Thank you @prudhvigodithi for the review. I look forward to the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the
bootstrap.keystoreandbootstrap.pluginsListfields to the OpenSearchCluster custom resource.This changes how the bootstrap pod is generated. The behavior is the same as with the
general.keystoreandgeneral.pluginsListfields.Issues Resolved
Closes #430 and #639.
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.